MWPW-204279 [MEP] Sync country spoofing with Target IP geo-fencing - #6623
Open
markpadbe wants to merge 3 commits into
Open
MWPW-204279 [MEP] Sync country spoofing with Target IP geo-fencing#6623markpadbe wants to merge 3 commits into
markpadbe wants to merge 3 commits into
Conversation
- Pair Target's mboxOverride.browserIp with akamaiLocale in the MEP spoofers via applyGeoSpoof (spoof-country-ip.js + test). - Add a Toggle-card switch that omits the `mep` param from the preview URL so the previewed page loads with no manifest parameters applied. Wired into setPreviewButton; covered by two overlay-logic tests.
The card collapse handler matched any `svg` inside a `.mep-card`, so clicking a Spoof Geo radio-row icon (an svg in the card body) bubbled up and toggled the card. Scope the trigger to `.mep-card h1 svg` so only the header chevron collapses the card. Adds a regression test.
Store the toggle state in sessionStorage so it survives a preview reload but clears when the tab closes (avoids a sticky, forgotten "don't apply manifests" state across QA sessions). Restored in setDefaultValues and written from the drawer change handler.
Contributor
AdobeLinhart
approved these changes
Sep 2, 2026
Contributor
|
Skipped merging 6623: MWPW-204279 [MEP] Sync country spoofing with Target IP geo-fencing due to insufficient approvals. Required: 2 approvals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spoofer only wrote
akamaiLocale, which spoofs geo for Milo's own resolutionbut NOT for Target — Target resolves geo from the real request IP at the Edge.
A new
applyGeoSpoofhelper now also emits Target'smboxOverride.browserIpQA param with a representative IP for the selected country, so one click
previews the same country across both Milo MEP and Target (no more falling
into US-only tests while spoofed to NG).
mepparam is omitted from the preview URL so the previewed page loads withno manifest parameters applied. The choice is persisted in sessionStorage, so
it survives a preview reload but clears when the tab closes.
collapse handler matched any
svgin the card (including the radio icons);it's now scoped to the header chevron only.
Preview/QA tooling only — all changed modules load exclusively under
config.mep?.preview, so production pages without MEP are unaffected.Resolves: MWPW-204279
Test URLs:
QA URL (Target geo-fence sync): https://www.stage.adobe.com/?milolibs=mep-spoof-mboxoverride-browserip&mepnext=on
akamaiLocale=ngandmboxOverride.browserIp=<NG IP>.ace1165v3.jsonno longer fires (checkttMETA), matching real NG-user behavior. It still fires when spoofed to US.