MWPW-180862: Respect section grid-width in how-to large-image/large-media variant - #6631
Open
DavidKHahn wants to merge 2 commits into
Open
MWPW-180862: Respect section grid-width in how-to large-image/large-media variant#6631DavidKHahn wants to merge 2 commits into
DavidKHahn wants to merge 2 commits into
Conversation
Contributor
DavidKHahn
force-pushed
the
mwpw-180862-grid-width-fix
branch
from
September 2, 2026 18:30
175c6f3 to
9bc847d
Compare
DavidKHahn
force-pushed
the
mwpw-180862-grid-width-fix
branch
from
September 2, 2026 18:51
9bc847d to
3cfafec
Compare
DavidKHahn
marked this pull request as draft
September 2, 2026 20:01
DavidKHahn
marked this pull request as ready for review
September 2, 2026 22:50
DavidKHahn
requested review from
KetakiD-Deshwandikar,
Ruchika4,
markovicpredrag1209 and
maxn-adobe
September 2, 2026 22:54
…edia variant The how-to block used its own global container-width variable instead of the section's grid-width-*, and a fixed 500px media column caused it to overflow past the section boundary. Media column now splits evenly with the list (matching the 380px Figma spec for grid-width-8) when nested in a grid-width section.
DavidKHahn
force-pushed
the
mwpw-180862-grid-width-fix
branch
from
September 3, 2026 16:29
3cfafec to
9bb8f0f
Compare
DavidKHahn
requested review from
a team,
Brandon32,
JasonHowellSlavin,
bandana147 and
meganthecoder
as code owners
September 3, 2026 16:29
JasonHowellSlavin
approved these changes
Sep 3, 2026
JasonHowellSlavin
left a comment
JasonHowellSlavin
left a comment
Contributor
There was a problem hiding this comment.
Two small nits. Looks good.
Addresses PR review comments on the leading-space indentation of the newly added section[class*='grid-width-'] rules.
Axelcureno
approved these changes
Sep 4, 2026
Axelcureno
left a comment
Axelcureno
left a comment
Member
There was a problem hiding this comment.
Matches the [class*='grid-width-'] pattern used elsewhere. One check: the new rule outranks .how-to.large-image.media-first .foreground, so media-first also goes 1fr 1fr in a grid-width section. Intended?
Contributor
|
Reminder to set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
how-toblock'slarge-image/large-mediavariant ignored the section'sgrid-width-*setting. It used its own global container-width variable instead of the section's already-narrowed width, and a fixed500pxmedia column (plus a460pxlist min-width) meant the block overflowed to ~1000px instead of the correct ~800px inside agrid-width-8section.Fix is scoped entirely to
how-to.css:max-widthwhen nested in agrid-width-*section, so it inherits the section's actual width (matches the existing pattern already used bytext-block/icon-block).minmax(0, 1fr) minmax(0, 1fr)) insidegrid-width-*sections instead of a rigid500pximage column, matching the confirmed Figma spec (media = 380px = exactly half of the 800px section, minus gap, at grid-width-8).Confirmed with design (Kyung Lee) that no changes to
section-metadata.csswere needed.Figma tech spec: https://www.figma.com/design/FTIF5N4h0FWtbyjvUyrd32/How-To?node-id=2842-45117
Resolves: MWPW-180862
Test URLs
Before: https://main--milo--adobecom.aem.page/drafts/klee/jira-ticket/mwpw-180862-grid-8-issue
After: https://mwpw-180862-grid-width-fix--milo--adobecom.aem.page/drafts/klee/jira-ticket/mwpw-180862-grid-8-issue
Live URL to test on (for QA): https://main--da-dc--adobecom.aem.page/acrobat/online/pdf-to-word?milolibs=mwpw-180862-grid-width-fix