[SR] Side-by-side: authorable body text color - #6656
Open
rgclayton wants to merge 2 commits into
Open
Conversation
added 2 commits
September 4, 2026 11:02
… show solid color.
…authoring pattern between the two - #6628
Contributor
rgclayton
changed the title
zagi25
approved these changes
Sep 7, 2026
Comment on lines
+70
to
+76
| &.body-color-subtle { | ||
| .card { | ||
| .foreground [class^='body-'] { | ||
| color: var(--s2a-color-content-subtle); | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Super nit: I guess we don't need to nest here
Suggested change
| &.body-color-subtle { | |
| .card { | |
| .foreground [class^='body-'] { | |
| color: var(--s2a-color-content-subtle); | |
| } | |
| } | |
| } | |
| &.body-color-subtle .card .foreground [class^='body-'] { | |
| color: var(--s2a-color-content-subtle); | |
| } |
overmyheadandbody
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an authorable body text color control to the
side-by-side(ace1209) block. By default, body copy inherits its color from the surrounding context; authors can opt into the subtle content token block-wide, and fine-tune per card using the per-card customization mechanism from #6628.Changes
[class^='body-']) now defaults tocolor: inheritinstead of being hardcoded to the subtle token only inside.card-stacked. Previously.card-overlayand.card-stackedhandled this inconsistently.body-color-subtle: applies the subtle content color token (--s2a-color-content-subtle) to body text on both cards.body-subtle/body-solid: authored asfirst-card-body-subtle,second-card-body-solid, etc., using the genericfirst-card-<token>/second-card-<token>pass-through mechanism added in MWPW-205892: Side-by-side per-card theming & customization #6628. Lets an author set the block-wide default and then dial an individual card back the other way.Authoring examples
Side by SideSide by Side (body-color-subtle)Side by Side (first-card-body-subtle)Side by Side (body-color-subtle, first-card-body-solid)Coordination with #6628
This update adds on to what @zagi25 worked on in #6628. All of those features/updates should work as expected.
Testing
side-by-sideunit tests pass.🤖 Generated with Claude Code