BRANDCON: pass host env into brand concierge bootstrap() - #6659
Open
loganzartman wants to merge 1 commit into
Open
BRANDCON: pass host env into brand concierge bootstrap()#6659loganzartman wants to merge 1 commit into
loganzartman wants to merge 1 commit into
Conversation
Forward the milo env name (stage|prod|local) to the brand concierge web client's bootstrap() call so the client can route its own NewRelic telemetry to the matching browser app entity. The web client treats env as optional (defaults to stage), so this and the web-client change can merge in either order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Contributor
|
SNOW Change Request Transaction ID: 0000019c1ef37582-210fcd23 |
mokimo
approved these changes
Sep 7, 2026
narcis-radu
requested changes
Sep 7, 2026
Contributor
There was a problem hiding this comment.
Hey @loganzartman - I am requesting changes because I noticed some missing / incorrect elements:
- PR is against
main, we're bypassing the normal flow. Unless this is tied to an exceptional release request, the code should go tostagefirst. - PR does not provide any QA / test pages
- PR does not handle C2 blocks. I see a mention about the C2 block being left untouched, but I really want to understand whether the change is needed or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Forward the milo env name (
stage|prod|local) fromgetConfig()into the Brand Concierge web client'sbootstrap()call.Why
The web client is adding its own NewRelic browser monitoring and needs to route telemetry to the correct browser-app entity (stage vs prod). Rather than sniff the hostname inside the embeddable client, milo already has the authoritative env signal — so we pass it through.
Merge-order independence
The web client treats
envas optional and defaults to stage when absent, so this PR and the web-client PR can merge in either order without breaking anything.Scope / notes
bcBootstrap); the global-nav variant reuses it.bcBootstrapunit test asserts individual fields and continues to pass.libs/c2/blocks/brand-concierge/bc-bootstrap.js; left untouched here sinceenvis optional (those surfaces safely default to stage). Can follow up if desired.🤖 Generated with Claude Code