[Release] Stage to Main - #6661
Open
milo-pr-merge[bot] wants to merge 6 commits into
Open
Conversation
* Add centralized video transcript modal button Authors pair a self-hosted video with a transcript by adding an adjacent fragment link whose hash starts with #transcript. decorateAutoBlock tags that link (video-transcript-source); the central decorateAnchorVideo path relocates it into the video's control cluster as an info button next to play/pause, reusing the existing modal machinery to open the transcript. Works for any block that produces a <video> (rich-content, video, carousel). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Style C2 transcript modal to match design Scope transcript-modal styling to .dialog-modal[id^="transcript"] so regular modals are unaffected: fixed 696px panel, rounded square close button, and a centered reading column for the body (paragraphs after the heading) while the header spans full width. Keep the scroll container height tracking the dialog so the last paragraph stays reachable on mobile. Remove stray comments and unneeded CSS nesting ampersands from the transcript changes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Adjust transcript modal bottom spacing Revert the max-height override that stopped the modal from scrolling and add bottom padding to the transcript content so the last line clears the edge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Announce transcript modal content to screen readers Wire aria-labelledby (heading) and aria-describedby (content) on the transcript dialog via the milo:modal:loaded event, scoped to [id^="transcript"] so other modals are unaffected. Without this the dialog had no accessible name or description, so VoiceOver announced only the title and Close button. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Remove ineffective transcript modal aria wiring The aria-labelledby duplicated the aria-label the C2 modal already sets from the heading, and VoiceOver does not announce a dialog's aria-describedby on open, so the listener was a no-op for the reported issue. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Make transcript control a button and tab before play/pause Add role=button plus Space-key activation to the transcript control, and insert it before the play/pause button so it is tabbed to first, matching its visual order. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Tokenize transcript button sizing and align with play/pause Use s2a spacing tokens for the transcript button size, icon size and offset, set a 2px gap, and add box-sizing: border-box so it matches the play/pause button exactly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Use the Figma transcript icon Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Use page placeholder config for transcript label Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * nest omitted transcription css under c2 foundation * Show link text on transcript button, style transcript modal curtain Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Indent transcript modal paragraphs 40px on mobile Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * update * Center transcript modal paragraphs on tablet/mobile with min 40px gutter Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Address PR 6583 review: raw px for dimensions, padding shorthand, drop !important Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Reset transcript link classes wholesale instead of hardcoded list Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Consolidate transcript CSS into video-transcript.css, prefetch its module earlier Move transcript button and modal styles out of the shared video.css/modal.css into a dedicated, lazily-loaded stylesheet colocated with video-transcript.js. Also kick off the module import from decorateAutoBlock, where transcript detection already happens, instead of only once the video finishes decorating. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Log silent bailouts in video-transcript instead of failing quietly Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Use getConfig codeRoot/miloLibs to load video-transcript.css Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Use existing .label utility class instead of duplicating typography tokens Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Move video-transcript into its own features folder Matches the existing language-banner/branch-quick-links convention of colocating a feature's JS and CSS in a dedicated libs/features/<name>/ folder. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * remove new lines * Replace magic spacing-token calc with named --play-pause-button-size var Addresses PR review feedback that the transcript-button right offset formula was unclear; the size now comes from a single variable shared with button.play-pause-button instead of repurposed spacing tokens. --------- Co-authored-by: Dusan Kosanovic <hit64474@adobe.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MWPW-205872 Cancel submit-failure timeout on success and surface hidden required fields
…dow (#6653) * fallback to reduced experience on short window * tighter threshold * last finetune
Contributor
Author
|
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot |
milo-pr-merge
Bot
requested review from
a team,
Brandon32,
JasonHowellSlavin and
meganthecoder
as code owners
September 7, 2026 09:18
Contributor
Contributor
|
SNOW Change Request Transaction ID: 0000019c1ef37582-215efca2 |
…#6543) Co-authored-by: Victor Hargrave <vhargrave@Victors-MacBook-Pro.local> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
* Implementing regionpriorities for case2 case 4 - languagebanner * Adding excludeUsUnlessExplicit logic for onlybanner flow --------- Co-authored-by: Snehal Sonawane <sonawane@adobe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo:
GNav Test URLs
Gnav + Footer + Region Picker modal:
Thin Gnav + ThinFooter + Region Picker dropup:
Localnav + Promo:
Sticky Branch Banner:
Inline Branch Banner:
Blog
RTL Locale