Skip to content

fixing crash in attemptTokenRefresh when adobeIMS.refreshToken() returns null #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arugupta1992 wants to merge 1 commit into
base: stage
Choose a base branch
from
Open

fixing crash in attemptTokenRefresh when adobeIMS.refreshToken() returns null #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions unitylibs/scripts/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export {

async function getRefreshToken() {
try {
const { tokenInfo } = window.adobeIMS ? await window.adobeIMS.refreshToken() : {};
return tokenInfo;
const res = window.adobeIMS ? await window.adobeIMS.refreshToken() : null;
return res?.tokenInfo ?? { token: null, isGuestToken: true };

@vipu0303 vipu0303 Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isGuestToken: true in this case?

@arugupta1992 arugupta1992 Aug 24, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user with no valid token is treated as guest user rather than erroring out. Followed the same convention here.

@vipu0303 vipu0303 Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not the invalid case, this is the case where adobeIMS has not been loaded yet. Do we want to retry in this case?

@arugupta1992 arugupta1992 Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are already retrying once in the parent.

} catch (e) {
const errorMsg = (e?.message || e?.exception?.message || '').trim();
if (errorMsg === 'invalid_credentials') {
Expand All @@ -61,7 +61,7 @@ async function getRefreshToken() {

async function attemptTokenRefresh() {
const refreshResult = await getRefreshToken();
if (!refreshResult.error) {
if (!refreshResult?.error) {
return { token: refreshResult, error: null };
}
return refreshResult;
Expand Down
Loading