Mwpw 204848 firefly unity showcase - #881
Open
SamSawant876 wants to merge 11 commits into
Open
Conversation
…com/unity into MWPW-204848-firefly-unity-showcase
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
sanjayms01
requested changes
Sep 2, 2026
sanjayms01
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for raising this PR!
Couple comments:
- Please remove all comments from the files. As much as they are helpful, we typically avoid adding comments to optimize on performance.
- Instead of calling
isFireflyRedesign()in your conditionals, maybe you can just add a class variable in the constructor that calls the function and then you can just refer to the class variable thereafter.
I also reviewed the test page and noticed few issues with the CSS. I have shared these in the ticket for your reference.
Please all pull the latest changes from stage when you get a chance so the PR is up to date.
added 3 commits
September 4, 2026 12:33
…com/unity into MWPW-204848-firefly-unity-showcase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary:
Resolves: MWPW-204848
Test URLs:
Screenshots:
