Skip to content

Mwpw 204848 firefly unity showcase - #881

Open
SamSawant876 wants to merge 11 commits into
stagefrom
MWPW-204848-firefly-unity-showcase
Open

Mwpw 204848 firefly unity showcase#881
SamSawant876 wants to merge 11 commits into
stagefrom
MWPW-204848-firefly-unity-showcase

Conversation

@SamSawant876

@SamSawant876 SamSawant876 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Change Summary:

  • Wire the Unity prompt-bar widget onto the new C2 rich-content block for the Firefly site-redesign PDP (additive target-config.json entry, doesn't touch existing hero-marquee/showcase-marquee/upload-marquee hosts)
  • Restyle the prompt widget for the Firefly redesign theme — card, verb-as-title header, prompt box, footer (model selector + Generate button), and both dropdowns ("Select a feature" and model list) — matched to Figma across lg/tablet/mobile breakpoints, gated entirely behind the firefly-redesign theme so the base widget is unchanged elsewhere
  • Replace hardcoded spacing/radius/color values with s2a design tokens where an exact match exists
  • Add per-verb placeholder text (:placeholder-input-image: / :placeholder-input-video:, falling back to the generic value)
  • Fix a crash when model-config fetch fails (modelDropdown() now guards against a non-array this.models)
  • Fix several latent base-widget bugs surfaced while rebuilding the dropdowns: the open/close animation silently fighting display/transform on menu open, checkmark position collapsing to position:absolute, and the model-list panel width/positioning

Resolves: MWPW-204848

Test URLs:

Screenshots:
Screenshot 2026-09-03 at 12 52 40 AM

@aem-code-sync

aem-code-sync Bot commented Sep 2, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@sanjayms01 sanjayms01 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this PR!

Couple comments:

  • Please remove all comments from the files. As much as they are helpful, we typically avoid adding comments to optimize on performance.
  • Instead of calling isFireflyRedesign() in your conditionals, maybe you can just add a class variable in the constructor that calls the function and then you can just refer to the class variable thereafter.

I also reviewed the test page and noticed few issues with the CSS. I have shared these in the ticket for your reference.

Please all pull the latest changes from stage when you get a chance so the PR is up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants