Conversation
✅ Deploy Preview for eclipsefdn-adoptium-trss canceled.
|
Update the parsing depending on the jdk implementation is used
karianna
left a comment
karianna
left a comment
There was a problem hiding this comment.
Would be good to add tests for this.
|
i had added a test case file could you check it and give me some feedbacks? |
|
@Sangyoon21 Thanks for the test coverage, that's a great start! It probably would be good to add a few more output variants for our common LTS's. e.g., For Java 8 I think there are some more examples in https://github.com/adoptium/api.adoptium.net/blob/main/adoptium-models-parent/adoptium-api-v3-models/src/test/kotlin/api/VersionParserTest.kt |
|
i had added some more test cases but i am not sure what should be the date for those different version. Could you clarify it please? |
|
@Sangyoon21 You mentioned the dates still look incorrect in the UI though? |
|
i am not sure about it, i cannot check it on my side right now. |
Are you not able to build locally? |
|
No, i am working locally but in the localhost3000(when i run ui version) the latest data point that is showing is only 2024-04-26. I cannot see further informations beyond that point. |
|
@llxia - Is that something you can help with? |
| if ((curRegexResult = javaVersionRegex.exec(output)) !== null) { | ||
| javaVersion = removeTimestamp(curRegexResult[1]); | ||
| } else { | ||
| javaVersion = output; // Use the entire output if markers are missing |
There was a problem hiding this comment.
If there is no javaVersionRegex match, we have no idea where the java -version is from and we should not handle the case.
There was a problem hiding this comment.
in this case than should i use return null instead?
There was a problem hiding this comment.
yes, in this case, there is no java -version output.
| `; | ||
|
|
||
| const result = parser.exactJavaVersion(java8Output); | ||
| expect(result.jdkDate).toBe('2024-06-27'); // Adjust the expected date based on your requirements |
There was a problem hiding this comment.
but i am not sure what should be the date for those different version. Could you clarify it please?
This was the part where i was not sure and had asked in the previous comment, so i had just added an random date.
There was a problem hiding this comment.
In this case, there is no jdk build date in java -version output.
|
To clarify, there could be 2 dates in java -version. For example:
The original issue is asking for getting the build date (not the release date). If there is no such a date, set null. We should not set a random date. |
|
I had fixed the changes. Please tell me if i have more things to change or update!! |
| // Return null if no jdkDate is found | ||
| if (!jdkDate) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Instead, add else at line 56
There was a problem hiding this comment.
you mean line 59?
There was a problem hiding this comment.
No, at line 56 add eles block
| } else if ((curRegexResult = javaBuildDateRegex.exec(output)) !== null) { | ||
| jdkDate = curRegexResult[0]; | ||
| } |
|
@Sangyoon21 could you rerun your test? Thanks |
|
I fixed it and here is the result of the test cases. I think it works now! |
3 participants
Fix #888
I changed it to parse the right jdk date but however i couldn't make the right jdk date showing in the graph.