Skip to content

Validate before binding whereIn values array #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
praem90 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Validate before binding whereIn values array #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/QueryBuilder/QueryBuilderHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ public function setFetchMode($mode)
*/
public function asObject($className, $constructorArgs = array())
{
var_dump('need to implement this'); die();
var_dump('need to implement this');
die();

return $this->setFetchMode(\PDO::FETCH_CLASS, $className, $constructorArgs);
}
Expand Down Expand Up @@ -282,7 +283,7 @@ public function getQuery($type = 'select', $dataToBePassed = array())
}

$queryArr = $this->adapterInstance->$type($this->statements, $dataToBePassed);

return $this->container->build(
'\\WpFluent\\QueryBuilder\\QueryObject',
array($queryArr['sql'], $queryArr['bindings'])
Expand Down Expand Up @@ -689,7 +690,9 @@ public function orWhereNot($key, $operator = null, $value = null)
*/
public function whereIn($key, $values)
{
return $this->whereHandler($key, 'IN', $values, 'AND');
return $this->when($values, function ($query, $values) use ($key) {
return $query->whereHandler($key, 'IN', $values, 'AND');
});
}

/**
Expand All @@ -700,7 +703,9 @@ public function whereIn($key, $values)
*/
public function whereNotIn($key, $values)
{
return $this->whereHandler($key, 'NOT IN', $values, 'AND');
return $this->when($values, function ($query, $values) use ($key) {
return $query->whereHandler($key, 'NOT IN', $values, 'AND');
});
}

/**
Expand All @@ -711,7 +716,9 @@ public function whereNotIn($key, $values)
*/
public function orWhereIn($key, $values)
{
return $this->whereHandler($key, 'IN', $values, 'OR');
return $this->when($values, function ($query, $values) use ($key) {
return $query->whereHandler($key, 'IN', $values, 'OR');
});
}

/**
Expand All @@ -722,7 +729,9 @@ public function orWhereIn($key, $values)
*/
public function orWhereNotIn($key, $values)
{
return $this->whereHandler($key, 'NOT IN', $values, 'OR');
return $this->when($values, function ($query, $values) use ($key) {
return $query->whereHandler($key, 'NOT IN', $values, 'OR');
});
}

/**
Expand Down