fix(analysis): aggregate — recover missing task names, open DBs by absolute path - #46
Open
maui314159 wants to merge 1 commit into
Open
maui314159 wants to merge 1 commit into
maui314159 wants to merge 1 commit into
Conversation
Two fixes for local aggregation, both cases where data vanished without an error. 1. `task_for` returned "unknown" whenever workspace.yaml was missing. Some archived local experiments kept only their retort.db, so their rows aggregated with no task and could not be grouped. Fall back to sniffing the generated artifacts: both tasks stamp their identity into every run's output (brazil-bench names its MCP server BrazilianSoccerMcp/brazilian_soccer_mcp and ships Kaggle CSV fixtures; rest-api-crud gets built as bookapi/book-api/bookshop). Returns None — never a guess — when neither signature is found, so an unrecognised experiment still falls through to "unknown" rather than being mislabelled. 2. Open each DB by ABSOLUTE path. SQLite's URI opener is unreliable with a relative `file:` path in mode=ro: depending on the DB's WAL/-shm state it spuriously raises "unable to open database file", which the OperationalError handler below swallows by design. Observed live: 20 of 21 local experiment DBs silently dropped out of the aggregate with no error surfaced. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for aggregation, both cases where data vanished without an error.
task_forreturned"unknown"wheneverworkspace.yamlwas missing. Some archived experiments keep only theirretort.db, so their rows aggregated with no task and could not be grouped. Now falls back to sniffing the generated artifacts: both workhorse tasks stamp their identity into every run's output (brazil-bench names its MCP serverBrazilianSoccerMcp/brazilian_soccer_mcpand ships Kaggle CSV fixtures; rest-api-crud gets built asbookapi/book-api/bookshop). ReturnsNone— never a guess — when neither signature is found, so an unrecognised experiment still falls through to"unknown"rather than being mislabelled.Open each DB by absolute path. SQLite's URI opener is unreliable with a relative
file:path inmode=ro: depending on the DB's WAL/-shm state it spuriously raises "unable to open database file", which theOperationalErrorhandler below swallows by design. Observed live: 20 of 21 experiment DBs silently dropped out of the aggregate with no error surfaced.Code-only; no experiment data included.
🤖 Generated with Claude Code
https://claude.ai/code/session_014UvPfQ4piCd1CAKXcdMW7X