Wagtail 2 fixes#2
Open
philgyford wants to merge 7 commits into
Open
Conversation
No longer present from Django 2.0
So it should still work for those using Wagtail < 2.0 as well as those on Wagtail 2.0+
Instead of importing `django_comments_xtd.models.XtdComment`, use the `django_comments_xtd.get_model()` method to get the model instead.
The `comments/_list_explore.html` tried to load `gravtar` template tags which do not exist, unless they're installed/created separately. Now use the [`xtd_comment_gravatar_url`](https://django-comments-xtd.readthedocs.io/en/latest/templatetags.html?highlight=template%20tags#filter-xtd-comment-gravatar-url) that's build into django-comments-xtd instead.
To be consistent with other Wagtail admin pages
Author
|
This continues to work with Wagtail 2.5 and Django 2.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some fixes to get this working on Wagtail 2 (I'm using Wagtail 2.4 and Django 2.1).
gravatartemplate tag (which is not included) withxtd_comment_gravtar_urlAlso:
COMMENTS_XTD_MODELsetting