Add support for the prices API#256
Open
yES wants to merge 1 commit into
Open
Conversation
a01c2e7 to
f92ff42
Compare
Collaborator
|
Thanks for taking over the PR @yES, I took a quick look to your PR but there are several issues with it:
Can you please fix these, and then I'll take a more thorough look at this ! |
63c3238 to
bfaccfc
Compare
Author
|
@feliixx thanks for comments! I fixed issues and now CI should works correctly |
Author
|
@feliixx could you review PR again please? |
Owner
|
@yES, looking at the current pull request, it looks like you did not address multiple of @feliixx's comments. Can you check? Keep in mind maintainers have limited time. Please make the PR perfect before asking any new review. I recommend looking at previous commits and other classes to see the coding style and what is expect. |
Author
|
I rechecked code and fixed all issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.