Skip to content

Add support for the prices API#256

Open
yES wants to merge 1 commit into
adrienverge:masterfrom
yES:prices-api
Open

Add support for the prices API#256
yES wants to merge 1 commit into
adrienverge:masterfrom
yES:prices-api

Conversation

@yES
Copy link
Copy Markdown

@yES yES commented Mar 6, 2026

@yES yES marked this pull request as ready for review March 6, 2026 11:26
@yES yES force-pushed the prices-api branch 2 times, most recently from a01c2e7 to f92ff42 Compare March 6, 2026 11:46
@feliixx
Copy link
Copy Markdown
Collaborator

feliixx commented Mar 26, 2026

Thanks for taking over the PR @yES,

I took a quick look to your PR but there are several issues with it:

  • the tests aren't succeeding -> please make sure that they pass locally. You can run them by launching a localStripe server and running ./test.sh
  • please make sure that flake8 . doesn't return any error
  • your IDE seems to have reformatted a bunch of files -> please remove all formatting related changes, as these changes are unrelated to the current PR and makes the overall diff harder to read

Can you please fix these, and then I'll take a more thorough look at this !

@yES yES force-pushed the prices-api branch 2 times, most recently from 63c3238 to bfaccfc Compare March 27, 2026 18:22
@yES
Copy link
Copy Markdown
Author

yES commented Mar 27, 2026

@feliixx thanks for comments! I fixed issues and now CI should works correctly

@yES
Copy link
Copy Markdown
Author

yES commented Apr 10, 2026

@feliixx could you review PR again please?

@adrienverge
Copy link
Copy Markdown
Owner

@yES, looking at the current pull request, it looks like you did not address multiple of @feliixx's comments. Can you check?

Keep in mind maintainers have limited time. Please make the PR perfect before asking any new review. I recommend looking at previous commits and other classes to see the coding style and what is expect.

@yES
Copy link
Copy Markdown
Author

yES commented Apr 27, 2026

I rechecked code and fixed all issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants