Skip to content

add sectional instruction files for code review#816

Merged
thostetler merged 1 commit intoadsabs:masterfrom
thostetler:copilot-review-improved-setup
Mar 2, 2026
Merged

add sectional instruction files for code review#816
thostetler merged 1 commit intoadsabs:masterfrom
thostetler:copilot-review-improved-setup

Conversation

@thostetler
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings March 2, 2026 14:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds repository-wide and scoped Copilot instruction files to standardize code review focus areas for this Next.js + TypeScript codebase (frontend, API/data, and tests/mocks).

Changes:

  • Added repository-wide Copilot review guidance in .github/copilot-instructions.md.
  • Added scoped instruction files under .github/instructions/ for frontend, API/data, and testing/mocks.
  • Defined applyTo globs so each instruction set targets the relevant parts of the repo.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/copilot-instructions.md Defines global Copilot review priorities, output style, and project baselines.
.github/instructions/frontend-review.instructions.md Scoped React/Next.js + Chakra UI review checklist for components/pages/styles.
.github/instructions/api-and-data.instructions.md Scoped guidance for API/data/middleware, focusing on contracts, state/cache, and security.
.github/instructions/testing-and-mocks.instructions.md Scoped guidance for test quality plus Vitest/Testing Library and MSW/mocks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@thostetler thostetler merged commit a7a0d97 into adsabs:master Mar 2, 2026
3 checks passed
@thostetler thostetler deleted the copilot-review-improved-setup branch March 2, 2026 14:30
@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.9%. Comparing base (6fde1a2) to head (12c059d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #816     +/-   ##
========================================
- Coverage    62.0%   61.9%   -0.0%     
========================================
  Files         317     317             
  Lines       36521   36521             
  Branches     1642    1642             
========================================
- Hits        22607   22605      -2     
- Misses      13877   13879      +2     
  Partials       37      37             

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants