SCIX-813 feat(nav): add count badge to graphics menu item#817
Draft
thostetler wants to merge 3 commits intoadsabs:masterfrom
Draft
SCIX-813 feat(nav): add count badge to graphics menu item#817thostetler wants to merge 3 commits intoadsabs:masterfrom
thostetler wants to merge 3 commits intoadsabs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #817 +/- ##
========================================
+ Coverage 62.0% 62.0% +0.1%
========================================
Files 317 317
Lines 36521 36522 +1
Branches 1642 1638 -4
========================================
+ Hits 22608 22619 +11
+ Misses 13876 13866 -10
Partials 37 37
🚀 New features to boost your workflow:
|
Also fix MSW graphics handler route (missing leading slash on :id param).
796687e to
7220a63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
staleTime: 5mintouseGetGraphicsCountto reduce redundant refetches when navigating between abstract subpages':id'→'/:id')Test plan
pnpm testpasses (890 tests, 0 failures)