Merged
Conversation
kelockhart
approved these changes
May 28, 2025
Member
kelockhart
left a comment
kelockhart
left a comment
There was a problem hiding this comment.
Looks fine, as long as you really don't need the month here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change deals with the problem described in issue #71. The problem is caused by date strings of the form
Jun-2024. The regular expression in thecrf.pyparser includes the year with the tag|na_month|(as described in the issue). The logic is such that when a month is detected, using the regular expression, code expects the tag to be present in theref_wordslist and therefore expects to be able to get the location of the tag in the list throughref_words.index('|na_month|').The solution is to make the regular expression ignore month expressions directly followed by a hyphen. Having the month really is not all the crucial anyway for matching references.