Conversation
tjacovich
requested changes
Jul 14, 2025
Contributor
tjacovich
left a comment
tjacovich
left a comment
There was a problem hiding this comment.
A few questions, mainly about the database migration and model updates.
vault_service/models.py
Outdated
| name = Column(String) | ||
| active = Column(Boolean) | ||
| scix_ui = Column(Boolean, nullable=True, server_default=sa.text('false'), default=False) | ||
| get_other_papers = Column(Boolean, nullable=True, server_default=sa.text('true'), default=True) |
Contributor
There was a problem hiding this comment.
We would want the model to match the nullability of the column in the upgrade.
vault_service/views/user.py
Outdated
| return json.dumps({'msg': 'No notification type passed'}), 400 | ||
|
|
||
| scix_ui_header = current_app.config['SCIXPLORER_HOST'] in request.headers.get('Host', '') | ||
| get_other_papers = False |
Contributor
There was a problem hiding this comment.
Do we want this to be false if the default elsewhere is true?
Contributor
Author
There was a problem hiding this comment.
It's now true everywhere
tjacovich
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://adsabs.atlassian.net/jira/software/c/projects/BKO/boards/16?assignee=712020%3Af4bc971e-93a7-483b-bbc2-2f0837046ac6&selectedIssue=BKO-508