SciX ID support for networks#44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains support for the SciX ID in the visualizations. Both the
Paper NetworkandAuthor Networkare generated by means of POST requests. These POST requests can either contain a query or a list of, before this PR, bibcodes. In the implementation of the networks within the context of the UI, only POST requests with aqueryin the payload are submitted. So, for the data gathering phase in theviews.pymodule, the following changes were implementedquery: thescix_idfield was added to the list of fields for which to retrieve data in a Solr querybibcodesparameter and the option of specifying anidentifiersfield was added to support the submission of other identifiers, specifically SciX IDsWhile programmatically not required, it felt "cleaner" to have a field called
identifiers. It should be noted that no applications are known that make use of this endpoint. This endpoint will function with SciX IDs as soon as they are indexed in theidentifierfield in production. The author network, using theidentifierspayload was successfully tested by submitting ASCL IDs, likeThe changes in the remainder of the networks consist of replacing the use of the word bibcode in comments and the replacement of the keyword
bibcodebyscix_idin data dictionaries. The actual calculation of the network and the clustering are done using integers.Unit tests were updated appropriately, together with stab data (by adding
scix_idfields to data structures).No changes were required for the
word-cloudendpoint. TheResults Graphis not part ofvis-services; it consists of a singleBigQueryquery from within the UI where it will have to be updated to use SciX IDs.