forked from KelvinTegelaar/CIPP-API
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from KelvinTegelaar:master #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+1,685
−1,952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make tenantFilter required on ExecSendPush
- Updated Set-CIPPNamedLocation to handle multiple IPs and locations for removal. - Enhanced Invoke-ExecNamedLocation to correctly process input values.
- Updated Set-CIPPNamedLocation to handle multiple IPs and locations for removal. - Enhanced Invoke-ExecNamedLocation to correctly process input values.
…into named-locations
Refactors Add-CIPPApplicationPermission to batch-create missing service principals and apply app role assignments using Microsoft Graph bulk requests. This improves efficiency and error handling when processing multiple permissions and service principals.
Added informational logging to Add-CIPPApplicationPermission for better traceability. Updated Invoke-ExecCPVRefresh to nest InstanceId under Metadata in the response body for improved response structure.
- Update product display names in ExcludeSkuList.JSON to match authoritative license data. - Implemented syncing logic in Update-LicenseSKUFiles.ps1 to automate updates.
Feat: Support removal of multiple IPs and locations
Chore: Sync product names in ExcludeSkuList.JSON
Add-CIPPDbItem now supports pipeline input for memory-efficient streaming, improved batch processing, and automatic count recording via -AddCount. Updated related cache scripts to use streaming and batch features, reducing memory usage and simplifying code. Added Set-CIPPDbCacheTestData.ps1 for generating large test datasets. Enhanced Add-CIPPAzDataTableEntity with performance logging.
…IPPDbItem Eliminated detailed timing and debug output from Add-CIPPAzDataTableEntity.ps1 to reduce log verbosity and improve performance. Commented out Write-Debug statements in Add-CIPPDbItem.ps1 and added property selection to Get-CIPPAzDataTableEntity for efficiency.
Improved client secret retrieval logic and error messaging in Invoke-ExecTokenExchange. Added organization and user info to Invoke-ExecListAppId response. Implemented retry logic for Key Vault secret retrieval in Get-CippKeyVaultSecret. Enhanced error normalization for AADSTS650051 in Get-NormalizedError. Minor code style and comment cleanups.
This update retrieves the application's web redirect URIs and adds a new redirect URI based on the current request if it is not already present. The change ensures the application's redirect URIs are kept up to date automatically during execution.
Wrapped the redirect URI update logic in a try/catch block to handle potential failures when updating application redirect URIs. Added logging for both successful and failed update attempts to improve troubleshooting and reliability.
Replaces multiple Microsoft Graph API calls with a single batch request to retrieve organization and domain information when adding a tenant. Adds logic to trigger a CPV permissions refresh for the new tenant by starting the appropriate orchestrator.
The success message now informs users that a permission refresh is queued and the tenant will be available shortly, providing clearer feedback after adding a tenant.
After updating the refresh token, immediately set it as an environment variable to make it available for subsequent operations. This applies to both the main tenant and additional tenants, ensuring the new token is accessible without delay.
Introduces a -Force switch to the Get-CIPPAuthentication function, allowing environment variables to be overwritten even if they are already set. Without the switch, existing environment variables are skipped. This is to avoid rate limits with the key vault api when we are adding separate tenants.
Replaces the immediate call to Start-UpdatePermissionsOrchestrator with logic to queue and start the permissions update orchestrator specifically for the partner tenant after updating the refresh token. Adds error handling and logging for orchestrator startup.
Feat: Add standard to enable windows diagnostic data settings in Intune
Removed eager loading of direct tenant secrets in Get-CIPPAuthentication and implemented lazy loading in Get-GraphToken. This change improves performance by only fetching secrets from storage or Key Vault when needed, rather than at authentication initialization.
Updated Push-CIPPTest to return @{ testRun = $false } when a test function is not found or an exception occurs, providing clearer feedback on test execution status.
Move test enumeration out of Invoke-CIPPDBTestsRun into a new Push-CIPPTestsList activity. Invoke-CIPPDBTestsRun now builds a batch of per-tenant CIPPTestsList activities and starts a 'TestsList' orchestrator, simplifying orchestration responsibility. Added Push-CIPPTestsList which enumerates Invoke-CippTest* functions, verifies tenant DB data, builds per-tenant test batches, and starts a per-tenant 'TestsRun_{Tenant}' orchestrator. Also updated logging/messages to reflect the new flow.
- Added 'AddOrganizerToSubject', 'DeleteSubject', and 'RemoveCanceledMeetings' to the calendar properties in Invoke-EditRoomMailbox and Invoke-ListRooms functions for enhanced functionality.
- Added support for dynamic inactive days based on input.
Feat: Enhance inactive user alert functionality with dynamic days setting
Feat: Add new calendar properties to room functions
Correction to last PR: Feat: Add standard to enable windows diagnostic data settings in Intune
Fix Get-CIPPAlertSmtpAuthSuccess by changing filter to 'Authenticated SMTP' instead of 'SMTP'
This reverts commit 8fbe5c4.
Bump DNSHealth module to 1.1.2 and migrate MailProviders into the new version folder. Replace $PSScriptRoot usages with the module base ($MyInvocation.MyCommand.Module.ModuleBase) for MailProviders file access. Add DMARC-aware handling for SPF soft-fail (~all) in Read-SpfRecord (accept when DMARC p=reject at 100%, otherwise recommend -all). Remove Quad9 DNS-over-HTTPS resolver support from Resolve-DnsHttpsQuery and Set-DnsResolver. Update Microsoft365 MX pattern to include mail.eo.outlook.com. Rename and update Barracuda provider JSON (new name/links). Refresh PSGetModuleInfo metadata to reflect version, dates and file list.
Fix - Alert on SMTP AUTH usage with success, helps to phase out SMTP AUTH (Entra P1 Required) returns nothing
Dev to hotfix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )