Parse "24:00" on the last day of month: Should return 0:00 of the first day of the next month

[hrigu]

# 24:00 of the last day of month: returns nil, should return 2019-08-01 00:00:00 +0200
Timeliness::Parser.parse("2019-07-31 24:00")
=> nil

# for non last day in month, it works as expected
Timeliness::Parser.parse("2019-07-30 24:00")
=> 2019-07-31 00:00:00 +0200

I can't imagine a reason for this behaviour. I've tested it with version 0.4.3.

Thank you for a fix, an explanation or a work-around!
Christian

[adzap]

I just ran both those values against 0.4.3 with no customisation and got nil both times, as I would expect. Since 24:00 is not supported by default.

Did you have any custom formats added before running this?

Can you past the output of Timeliness::Definitions.datetime_format_set.formats

[hrigu]

No, I'm not aware of any custom formats. The available formats are:

Timeliness::Definitions.datetime_format_set.formats
=> ["yyyy-mm-dd hh:nn:ss.u", 
"yyyy-mm-dd hh:nn:ss", 
"yyyy-mm-dd h:nn", 
"yyyy-mm-dd h:nn_ampm", 
"m/d/yy h:nn:ss", 
"m/d/yy h:nn_ampm", 
"m/d/yy h:nn", 
"d/m/yy hh:nn:ss", 
"d/m/yy h:nn_ampm", 
"d/m/yy h:nn", 
"dd-mm-yyyy hh:nn:ss", 
"dd-mm-yyyy h:nn_ampm", 
"dd-mm-yyyy h:nn", 
"ddd, dd mmm yyyy hh:nn:ss tz", 
"ddd, dd mmm yyyy hh:nn:ss zo", 
"ddd mmm d hh:nn:ss zo yyyy", 
"yyyy-mm-ddThh:nn:ss", 
"yyyy-mm-ddThh:nn:sszo", 
"yyyy-mm-ddThh:nn:sszt", 
"yyyy-mm-ddThh:nn:ss.u", 
"yyyy-mm-ddThh:nn:ss.uzo", 
"yyyy-mm-ddThh:nn:ss.uzt", 
"yyyy-mm-dd hh:nn:ss zo", 
"yyyy-mm-dd hh:nn:ss tz", 
"yyyy-mm-dd hhnn", 
"yyyy-mm-dd hh", 
"yyyy-mm-dd hh.nn"
]