Network optimization 2 by orangishcat · Pull Request #132 · aehmttw/Tanks

orangishcat · 2026-03-29T06:46:51Z

Merge the other one first
Remove all the write and read methods (excluding a few with unsupported types)
Add validation to registered events to ensure reading, writing, and types are correct
TankPlayerRemote.quickActions changed from boolean array to an int, where each bit of the integer serves as a boolean

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/Game.java # src/main/java/tanks/hotbar/ItemBar.java # src/main/java/tanks/network/event/EventSetItemCount.java # src/main/java/tanks/network/event/EventTankUpdateHealth.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/Game.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/hotbar/ItemBar.java # src/main/java/tanks/network/event/EventAddNPCShopItem.java # src/main/java/tanks/network/event/EventAddShopItem.java # src/main/java/tanks/network/event/EventSortShopButtons.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/network/event/EventExplosion.java

# Conflicts: # src/main/java/tanks/AreaEffectFreeze.java # src/main/java/tanks/Chunk.java # src/main/java/tanks/DebugKeybinds.java # src/main/java/tanks/Game.java # src/main/java/tanks/Level.java # src/main/java/tanks/ModAPI.java # src/main/java/tanks/Panel.java # src/main/java/tanks/attribute/AttributeModifier.java # src/main/java/tanks/bullet/Bullet.java # src/main/java/tanks/bullet/BulletAirStrike.java # src/main/java/tanks/bullet/BulletInstant.java # src/main/java/tanks/bullet/BulletReboundIndicator.java # src/main/java/tanks/gui/screen/ScreenDebug.java # src/main/java/tanks/item/Item.java # src/main/java/tanks/network/Client.java # src/main/java/tanks/network/ClientHandler.java # src/main/java/tanks/network/MessageReader.java # src/main/java/tanks/network/NetworkEventMap.java # src/main/java/tanks/network/NetworkUtils.java # src/main/java/tanks/network/Server.java # src/main/java/tanks/network/ServerHandler.java # src/main/java/tanks/network/event/EventAddColoredTile.java # src/main/java/tanks/network/event/EventAddFixedShape.java # src/main/java/tanks/network/event/EventAddNPC.java # src/main/java/tanks/network/event/EventAddObstacle.java # src/main/java/tanks/network/event/EventAddObstacleBullet.java # src/main/java/tanks/network/event/EventAddObstacleText.java # src/main/java/tanks/network/event/EventAddScoreboard.java # src/main/java/tanks/network/event/EventAirdropTank.java # src/main/java/tanks/network/event/EventAnnounceConnection.java # src/main/java/tanks/network/event/EventArcadeClearMovables.java # src/main/java/tanks/network/event/EventArcadeFrenzy.java # src/main/java/tanks/network/event/EventBeginLevelCountdown.java # src/main/java/tanks/network/event/EventBulletBounce.java # src/main/java/tanks/network/event/EventBulletDestroyed.java # src/main/java/tanks/network/event/EventBulletInstantWaypoint.java # src/main/java/tanks/network/event/EventBulletReboundIndicator.java # src/main/java/tanks/network/event/EventBulletStunEffect.java # src/main/java/tanks/network/event/EventBulletUpdateTarget.java # src/main/java/tanks/network/event/EventChangeBackgroundColor.java # src/main/java/tanks/network/event/EventChangeScoreboardAttribute.java # src/main/java/tanks/network/event/EventChat.java # src/main/java/tanks/network/event/EventClearNPCShop.java # src/main/java/tanks/network/event/EventClearShop.java # src/main/java/tanks/network/event/EventConnectionSuccess.java # src/main/java/tanks/network/event/EventCreateFreezeEffect.java # src/main/java/tanks/network/event/EventDisplayText.java # src/main/java/tanks/network/event/EventDisplayTextGroup.java # src/main/java/tanks/network/event/EventEnterLevel.java # src/main/java/tanks/network/event/EventItemDrop.java # src/main/java/tanks/network/event/EventItemPickup.java # src/main/java/tanks/network/event/EventKick.java # src/main/java/tanks/network/event/EventLayMine.java # src/main/java/tanks/network/event/EventLevelExit.java # src/main/java/tanks/network/event/EventLevelFinished.java # src/main/java/tanks/network/event/EventLoadItemBarSlot.java # src/main/java/tanks/network/event/EventLoadLevel.java # src/main/java/tanks/network/event/EventMutePlayer.java # src/main/java/tanks/network/event/EventNudge.java # src/main/java/tanks/network/event/EventObstacleBoostPanelEffect.java # src/main/java/tanks/network/event/EventObstacleDestroy.java # src/main/java/tanks/network/event/EventObstacleShrubberyBurn.java # src/main/java/tanks/network/event/EventPing.java # src/main/java/tanks/network/event/EventPlayerAutoReady.java # src/main/java/tanks/network/event/EventPlayerAutoReadyConfirm.java # src/main/java/tanks/network/event/EventPlayerChat.java # src/main/java/tanks/network/event/EventPlayerReady.java # src/main/java/tanks/network/event/EventPlayerRevealBuild.java # src/main/java/tanks/network/event/EventPlayerSetBuild.java # src/main/java/tanks/network/event/EventPurchaseBuild.java # src/main/java/tanks/network/event/EventPurchaseNPCItem.java # src/main/java/tanks/network/event/EventReturnToCrusade.java # src/main/java/tanks/network/event/EventReturnToLobby.java # src/main/java/tanks/network/event/EventScoreboardUpdateScore.java # src/main/java/tanks/network/event/EventSendClientDetails.java # src/main/java/tanks/network/event/EventSendTankColors.java # src/main/java/tanks/network/event/EventSetItem.java # src/main/java/tanks/network/event/EventSetItemBarSlot.java # src/main/java/tanks/network/event/EventSetItemCount.java # src/main/java/tanks/network/event/EventSetupHotbar.java # src/main/java/tanks/network/event/EventShareCrusade.java # src/main/java/tanks/network/event/EventShareLevel.java # src/main/java/tanks/network/event/EventShootBullet.java # src/main/java/tanks/network/event/EventShowCrusadeStats.java # src/main/java/tanks/network/event/EventSortNPCShopButtons.java # src/main/java/tanks/network/event/EventTankAddAttributeModifier.java # src/main/java/tanks/network/event/EventTankCharge.java # src/main/java/tanks/network/event/EventTankControllerUpdateC.java # src/main/java/tanks/network/event/EventTankControllerUpdateS.java # src/main/java/tanks/network/event/EventTankCreate.java # src/main/java/tanks/network/event/EventTankCustomCreate.java # src/main/java/tanks/network/event/EventTankMimicLaser.java # src/main/java/tanks/network/event/EventTankMimicTransform.java # src/main/java/tanks/network/event/EventTankPlayerCreate.java # src/main/java/tanks/network/event/EventTankSpawn.java # src/main/java/tanks/network/event/EventTankTeleport.java # src/main/java/tanks/network/event/EventTankTransformCustom.java # src/main/java/tanks/network/event/EventTankTransformPreset.java # src/main/java/tanks/network/event/EventTankUpdate.java # src/main/java/tanks/network/event/EventTankUpdateColor.java # src/main/java/tanks/network/event/EventTankUpdateHealth.java # src/main/java/tanks/network/event/EventTankUpdateVisibility.java # src/main/java/tanks/network/event/EventUpdateCoins.java # src/main/java/tanks/network/event/EventUpdateEliminatedPlayers.java # src/main/java/tanks/network/event/EventUpdateReadyPlayers.java # src/main/java/tanks/network/event/EventUpdateRemainingLives.java # src/main/java/tanks/network/event/EventUpdateTankAbility.java # src/main/java/tanks/network/event/INetworkEvent.java # src/main/java/tanks/network/event/IStackableEvent.java # src/main/java/tanks/network/event/PersonalEvent.java # src/main/java/tanks/network/event/online/EventAddButton.java # src/main/java/tanks/network/event/online/EventAddMenuButton.java # src/main/java/tanks/network/event/online/EventAddShape.java # src/main/java/tanks/network/event/online/EventAddText.java # src/main/java/tanks/network/event/online/EventAddTextBox.java # src/main/java/tanks/network/event/online/EventAddUUIDTextBox.java # src/main/java/tanks/network/event/online/EventSendLevelToDownload.java # src/main/java/tanks/network/event/online/EventSendOnlineClientDetails.java # src/main/java/tanks/network/event/online/EventSetPauseScreenTitle.java # src/main/java/tanks/network/event/online/EventUploadLevel.java # src/main/java/tanks/obstacle/Obstacle.java # src/main/java/tanks/tank/Mine.java # src/main/java/tanks/tank/Tank.java # src/main/java/tanks/tank/TankPlayerRemote.java # src/main/java/tanks/tank/TankRemote.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

ghostlypi

Some thoughts and questions. I've definitely accidentally scoped up some stuff, however, I'd discourage implementing those in this PR. Considering them would, however, be a good idea.

ghostlypi · 2026-04-01T04:16:10Z

Doesn't TCP preserve order even without additional code?

Also, a stylistic thing, please don't just push AI code. You are allowed to use AI, however for copyright and license reasons, the AI code should be derivative of your work, not the other way around.

Yeah this was from the old PR 6 months ago and I long ago decided I didn't like it either. It's no longer used, evidently I forgot to delete it

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat added 30 commits September 9, 2025 23:10

refactor: create NetworkHandler for shared properties

7e13d4c

Signed-off-by: orangishcat <fdsnail2@gmail.com>

feat: network optimizations, reflection handlers

1a24258

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: network event fixes

dc4832d

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: use shorts for colors

fb7aec3

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix(network): network-related bug fixes

f45056b

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix(EventTankUpdateHealth): shield fix

7057b13

Signed-off-by: orangishcat <fdsnail2@gmail.com>

style: minor code style changes

5584102

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: shoot bullet event

817e29f

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: remove stacked group event

6c39fa7

Signed-off-by: orangishcat <fdsnail2@gmail.com>

feat: more network validation checks

c60e604

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: interpolation bug

ddda007

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: more interpolation bugs

096f35e

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: explosion bug

c1082d4

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: partial angle interpolation fix

8073cbc

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: duplicate obstacle destroy events from explosion

db1605a

Signed-off-by: orangishcat <fdsnail2@gmail.com>

refactor: extract duplicate code

60b3738

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: preserve order by batching all events

cf18fbb

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix,style: make more events stackable, optimize imports

8fc13e4

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: make instant waypoint events stackable

f92fab3

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: optimize network load of 0 cooldown items

d4a8853

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: change debug option back to false

b8b0483

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: stack bullet events only for zero cooldown shots

455f8c5

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: continuous shooting only for low cooldown bullets,

0d47c5c

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: set event data debug to false

a8dfed6

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: use int for quick actions encoding

3ff9442

Signed-off-by: orangishcat <fdsnail2@gmail.com>

Merge branch 'remote-master' into network-optimization-cleaned

c91254a

# Conflicts: # src/main/java/tanks/Game.java # src/main/java/tanks/hotbar/ItemBar.java # src/main/java/tanks/network/event/EventSetItemCount.java # src/main/java/tanks/network/event/EventTankUpdateHealth.java

chore: update branch

6db2cf0

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: event lay mine

b5f74cf

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: sounds not playing on client side

0b6a164

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: add sounds back, fix tank health inconsistency

d96c4cf

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat added 8 commits December 1, 2025 22:52

Merge branch 'remote-master' into network-optimization-cleaned

8d98c11

# Conflicts: # src/main/java/tanks/Game.java

chore: update branch

058a962

Signed-off-by: orangishcat <fdsnail2@gmail.com>

chore: update branch, fix build errors

f7c9d1d

Signed-off-by: orangishcat <fdsnail2@gmail.com>

Merge branch 'remote-master' into network-optimization-cleaned

b4d0125

# Conflicts: # src/main/java/tanks/network/event/EventExplosion.java

chore: merge branch

15c9203

Signed-off-by: orangishcat <fdsnail2@gmail.com>

chore: delete all the read and write methods

ef69f2b

Signed-off-by: orangishcat <fdsnail2@gmail.com>

ghostlypi reviewed Apr 1, 2026

View reviewed changes

fix: delete unused methods, add comment

207d90e

Signed-off-by: orangishcat <fdsnail2@gmail.com>

ghostlypi reviewed Apr 2, 2026

View reviewed changes

Comment thread src/main/java/tanks/tank/Explosion.java Outdated

fix: explosion radius, move ReflectionHandle.java

bee413b

Signed-off-by: orangishcat <fdsnail2@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Network optimization 2#132

Network optimization 2#132
orangishcat wants to merge 40 commits into
aehmttw:masterfrom
orangishcat:network-optimization-2

orangishcat commented Mar 29, 2026 •

edited

Loading

Uh oh!

ghostlypi left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghostlypi Apr 1, 2026

Uh oh!

ghostlypi Apr 1, 2026

Uh oh!

orangishcat Apr 1, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

orangishcat commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghostlypi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghostlypi Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

orangishcat Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

orangishcat commented Mar 29, 2026 •

edited

Loading

orangishcat Apr 1, 2026 •

edited

Loading