Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the CI deploy strategy so that stage deployments are gated behind merges to the
stagebranch rather than triggered by any PR tomain. Previously, anyone with push permissions could deploy to stage just by opening a PR, meaning testing happened against a shared stage environment that any open PR could overwrite.Changes
deploy_stage.yml— trigger changed frompull_request→maintopush→stage. The full pipeline (test → deploy → post-deploy smoke test) now runs only when code is merged intostage.test.yml(new) — runs thetestjob on PRs to bothmainandstage, so unit tests still gate every PR without touching a live environment.Resulting flow
main/stagestagemainNotes
/versionendpoint on the stage namespace, and now only runs post-merge — PRs never touch a live environment.deploy_stage.ymlstill runstestbefore deploying, so a broken merge tostagewon't deploy.stage(require PR + theTestcheck).