Skip to content

[ENH] Fix inverted label mapping in OutlierDetectionAdapter & add adapter tests#3209

Open
Adityakushwaha2006 wants to merge 14 commits intoaeon-toolkit:mainfrom
Adityakushwaha2006:test/collection-adapters
Open

[ENH] Fix inverted label mapping in OutlierDetectionAdapter & add adapter tests#3209
Adityakushwaha2006 wants to merge 14 commits intoaeon-toolkit:mainfrom
Adityakushwaha2006:test/collection-adapters

Conversation

@Adityakushwaha2006
Copy link
Copy Markdown
Contributor

Reference Issues/PRs

Fixes #3184
Addresses the request for targeted test coverage for collection anomaly detection adapters.
Fixes a logic error discovered in OutlierDetectionAdapter.

What does this implement/fix? Explain your changes.

This PR adds unit tests for ClassificationAdapter and OutlierDetectionAdapter as requested and fixes a critical logic bug in the outlier adapter.

1. Bug Fix in OutlierDetectionAdapter

  • Issue: The previous implementation incorrectly mapped outliers (-1) to 0 (Normal) and inliers (1) to 1 (Anomaly).
  • Fix: Updated _predict in aeon/anomaly_detection/collection/_outlier_detection.py to correctly map -1 to 1 (Anomaly).
    • Old Logic: pred[pred == -1] = 0 (Incorrect)
    • New Logic: return (pred == -1).astype(int) (Correct: Outlier becomes Anomaly/True)

2. Added Targeted Tests
Added two new test files focusing exclusively on the adapter "translation" logic (avoiding generic shape/crash tests covered by check_estimator):

  • aeon/anomaly_detection/collection/tests/test_outlier_detection.py: Verifies that Sklearn labels (-1, 1) are correctly translated to Aeon standards (1, 0). Includes a safety test to ensure no raw -1 values leak into the output.
  • aeon/anomaly_detection/collection/tests/test_classification.py: Verifies that the ClassificationAdapter acts as a transparent passthrough for binary labels.

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

The tests use DummyClassifier and DummyOutlierDetector mocks to ensure they are fast, deterministic, and do not require training real models.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added anomaly detection Anomaly detection package bug Something isn't working labels Dec 28, 2025
@aeon-actions-bot
Copy link
Copy Markdown
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ anomaly detection ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

@SebastianSchmidl SebastianSchmidl changed the title [BUG] Fix inverted label mapping in OutlierDetectionAdapter & add adapter tests [ENH] Fix inverted label mapping in OutlierDetectionAdapter & add adapter tests Dec 28, 2025
@SebastianSchmidl SebastianSchmidl added the enhancement New feature, improvement request or other non-bug code enhancement label Dec 28, 2025
…sts with IsolationForest & RandomForestClassifier
Copy link
Copy Markdown
Member

@SebastianSchmidl SebastianSchmidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍🏼

Just some minor documentation improvements

Co-authored-by: Sebastian Schmidl <10573700+SebastianSchmidl@users.noreply.github.com>
Co-authored-by: Sebastian Schmidl <10573700+SebastianSchmidl@users.noreply.github.com>
Copy link
Copy Markdown
Member

@SebastianSchmidl SebastianSchmidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait until @MatthewMiddlehurst had a chance to look at this as well. I'm not super sure that we do not already have some dummy fixtures for the tests.

Copy link
Copy Markdown
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on the output, got the labels backwards!

If you go into the testing module we have some pre-made testing data which can be used here instead of creating it when we don't need to. This is pretty minor though, so can merge without it if no change is made.

Co-authored-by: Sebastian Schmidl <10573700+SebastianSchmidl@users.noreply.github.com>
@MatthewMiddlehurst
Copy link
Copy Markdown
Member

currently failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

anomaly detection Anomaly detection package bug Something isn't working enhancement New feature, improvement request or other non-bug code enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] Add test coverage for anomaly_detection.collection estimators

3 participants