Skip to content

[BUG] Fix RandomState handling in ROCKET and Hydra transformers#3214

Draft
satwiksps wants to merge 18 commits intoaeon-toolkit:mainfrom
satwiksps:rocket-randomstate
Draft

[BUG] Fix RandomState handling in ROCKET and Hydra transformers#3214
satwiksps wants to merge 18 commits intoaeon-toolkit:mainfrom
satwiksps:rocket-randomstate

Conversation

@satwiksps
Copy link
Copy Markdown
Contributor

@satwiksps satwiksps commented Dec 29, 2025

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR fixes a bug where passing a RandomState object to the random_state parameter in ROCKET-based and Hydra transformers resulted in the seed being ignored (falling back to None) or causing crashes in backend computations.

Changes implemented:

  1. Standardised Seed Handling: Updated the _fit methods in Rocket, MiniRocket, MultiRocket, HydraTransformer, and ROCKETGPU. Now uses sklearn.utils.check_random_state to process the input random_state.
  2. Deterministic Backend Seeding: Explicitly generates a 32-bit integer seed from the checked RandomState to pass to the underlying computation backends (Numba, PyTorch, and TensorFlow), ensuring reproducibility regardless of whether an int, None, or RandomState object is provided.
  3. RocketGPU Stability: Fixed a crash in ROCKETGPU caused by data type mismatches between float32 inputs and float64 kernels/biases generated by numpy. Explicitly casts generated parameters and inputs to float32 to ensure compatibility with TensorFlow's conv1d.
  4. Note on Test Updates: The regression tests in test_all_rockets.py and _rockad.py were updated. Since the random seeding logic was corrected, the deterministic stream of random numbers changed, necessitating updates to the hardcoded expected output values.

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

I have verified these changes with a local test script that confirms:

  • Reproducibility when passing identical RandomState objects.
  • Reproducibility when passing integer seeds.
  • No regressions in default behavior.
  • ROCKETGPU no longer crashes on standard inputs.

PR checklist

For all contributions

  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

For new estimators and functions

  • I've added the estimator/function to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.

For developers with write access

  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working transformations Transformations package labels Dec 29, 2025
@aeon-actions-bot
Copy link
Copy Markdown
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ transformations ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

@satwiksps satwiksps marked this pull request as draft December 29, 2025 20:58
@SebastianSchmidl SebastianSchmidl removed their request for review December 31, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working transformations Transformations package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ROCKET transform random number generation

1 participant