You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
predict(X) was returning scores for the entire accumulated series instead
of just the new input X. After fit(20 points), predict(15 points) would
return 35 scores instead of 15.
Root cause: fit_is_empty was True, so the base class skipped fit()
during fit_predict(), leaving self.mp as None when _predict() ran.
Changes:
Set fit_is_empty to False
_fit() now initialises stumpy on only the first n_init_train points
_predict() prepends zeros for the init region and scores only new points
Replaced reverse_windowing with end-of-window score assignment
No new dependencies introduced.
Only _left_stampi.py and its test file are changed.
All unit tests pass locally.
I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ anomaly detection ]. Feel free to change these if they do not properly represent the PR.
The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.
If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.
Don't hesitate to ask questions on the aeonDiscord channel if you have any.
PR CI actions
These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.
Run pre-commit checks for all files
Run mypy typecheck tests
Run all pytest tests and configurations
Run all notebook example tests
Run numba-disabled codecov tests
Stop automatic pre-commit fixes (always disabled for drafts)
Disable numba cache loading
Regenerate expected results for testing
Push an empty commit to re-run CI checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2819
predict(X) was returning scores for the entire accumulated series instead
of just the new input X. After fit(20 points), predict(15 points) would
return 35 scores instead of 15.
Root cause: fit_is_empty was True, so the base class skipped fit()
during fit_predict(), leaving self.mp as None when _predict() ran.
Changes:
No new dependencies introduced.
Only _left_stampi.py and its test file are changed.
All unit tests pass locally.