chore(secrets): rename MCP_SECRETS_PAT -> GH_SECRETS_PAT, standardize for MCP + Grok#774
Merged
Merged
Conversation
… for MCP + Grok One secrets-write PAT now serves both OAuth refresh-persistence paths: - MCP OAuth (scripts/mcp-oauth-refresh.sh), and - Grok X-account OAuth (scripts/run-grok.sh section 2b, landed in #773). Both read GH_SECRETS_PAT and fall back to GH_GLOBAL. #773 reused the MCP-named PAT as an interim; this generalizes the name now that it drives two features. MCP_SECRETS_PAT was still under [Unreleased], so no tagged release ever shipped it: operators tracking main who already set it should re-add the PAT as GH_SECRETS_PAT; GH_GLOBAL users are unaffected. - scripts/run-grok.sh, scripts/mcp-oauth-refresh.sh: read GH_SECRETS_PAT // GH_GLOBAL - aeon.yml / messages.yml: grok install/run env now passes GH_SECRETS_PAT - dashboard: secrets-catalog entry + McpPanel + GrokAuthModal point at GH_SECRETS_PAT; the catalog description + secrets reference now name both MCP and the Grok harness - docs (harnesses, mcp-oauth, CONFIGURATION) + .claude skill references - CHANGELOG: rename note under Changed - tests updated; test_run_grok.sh + test_mcp_oauth_refresh.sh both green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the secrets-write PAT
MCP_SECRETS_PAT->GH_SECRETS_PATacross the repo, so one standardized PAT serves both OAuth refresh-persistence paths:scripts/mcp-oauth-refresh.sh)scripts/run-grok.sh§2b, landed in fix(grok): persist rotated OAuth refresh token so GROK_CREDENTIALS survives past 6h #773)Both read
GH_SECRETS_PATand fall back toGH_GLOBAL.Why
#773 added the grok durable-refresh and reused the MCP-named PAT as an interim. Now that a single secrets-write credential drives two features, its name should reflect that.
MCP_SECRETS_PATwas still under[Unreleased](never shipped in a tagged release), so this is the cheapest moment to standardize the name.Scope
Pure rename + two wording touch-ups, 18 files:
run-grok.sh,mcp-oauth-refresh.shreadGH_SECRETS_PAT // GH_GLOBAL.aeon.yml/messages.ymlgrok env now passesGH_SECRETS_PAT.secrets-catalogentry +McpPanel+GrokAuthModalpoint atGH_SECRETS_PAT; the catalog description and thesecrets.mdreference now name both MCP and the Grok harness.harnesses.md,mcp-oauth.md,CONFIGURATION.md,.claude/skills/aeon/references/{mcp,secrets}.md,skills/robinhood-mcp/SKILL.md.Operator impact
Anyone tracking
mainwho already setMCP_SECRETS_PATshould re-add the PAT asGH_SECRETS_PAT.GH_GLOBALusers are unaffected (still the fallback). No tagged release shipped the old name.Test
bash scripts/tests/test_run_grok.sh-> ALL PASSbash scripts/tests/test_mcp_oauth_refresh.sh-> ALL PASSactionlintclean; workflows parse.