Skip to content

test: cover the search row and version-history dialog #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronjmars merged 2 commits into from
Jul 20, 2026
Merged

test: cover the search row and version-history dialog #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
309cdf4
test: cover the search row and version-history dialog
aaronjmars Jul 20, 2026
ee325cd
fix: regenerate the lockfile with the pinned npm
aaronjmars Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions components/dialogs/version-history-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,16 @@ export function VersionHistoryDialog({ deckId, open, onOpenChange }: Props) {
</p>

{/*
The dialog itself stays mounted for the lifetime of the sidebar, so
the list is split out and mounted per-open, keyed by deck. That makes
`useState`'s initial value the reset: reopening, or switching decks
while open, starts from the loading state without an effect having to
synchronously roll it back.
This component stays mounted for the lifetime of the sidebar, so any
state it held directly would survive every open — which is why the
old version had to lower a loading flag from an effect. Holding the
state one level down instead makes `useState`'s initial value the
reset, because DialogContent unmounts its children on close.

The `key` covers the case the unmount does not: switching decks while
the dialog is already open. Without it the list keeps the previous
deck's rows on screen until the new read resolves. The `open` check
is belt-and-braces — DialogContent already gates this subtree.
*/}
{open && deckId ? (
<SnapshotList
Expand Down
Loading