feat: dictionary infrastructure for v0.2#2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DictionaryBuilderandDictionary::fromRows()so dictionary rows only carry author fields (term,category,severity) whilenormalizedlookup keys are derived at build time.TurkishProfilethroughNormalizationPipelineso dictionary index keys use the same normalization chain as runtime matching.data/tr.phpto author-only rows and addtests/DictionaryTest.php(12 unit tests).CHANGELOG.md,docs/specification.md, andREADME.md.Breaking changes (v0.2)
Dictionary::fromArray()removed — useDictionary::fromRows($rows, $normalizeKey)instead.normalizedfield.Test plan
composer validatecomposer test— 63 passed (100 assertions)normalizedrejectionMade with Cursor