[CLIENT-2790] Deprecate value_byte_size parameter in several bitwise operation functions - #577
Draft
juliannguyen4 wants to merge 22 commits into
Draft
[CLIENT-2790] Deprecate value_byte_size parameter in several bitwise operation functions#577juliannguyen4 wants to merge 22 commits into
juliannguyen4 wants to merge 22 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #577 +/- ##
==========================================
- Coverage 85.63% 85.61% -0.03%
==========================================
Files 102 102
Lines 15020 15032 +12
==========================================
+ Hits 12863 12870 +7
- Misses 2157 2162 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…value_byte_size
…_size' into CLIENT-2790-deprecate-value_byte_size
…value_byte_size
…value_byte_size
…value_byte_size
…e-value_byte_size
…_t. in practice the value argument shouldn't be larger than the max size of a record. TODO: better error handling should be added regarding outrageously large bytearray parameters
…esn't return byte_count for Python bytes
…ehavior in trunk where value_byte_size > UINT32_MAX raises a client error
This reverts commit 2bd2ade.
… Per Shannon's last code review for CLIENT-4678, using goto statements to return errors aren't idiomatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO
https://aerospike-python-client--577.org.readthedocs.build/en/577/aerospike_helpers.operations.html#aerospike_helpers.operations.bitwise_operations.bit_and