Skip to content

fix: change logging output from stdout to stderr#4

Open
aeroxy wants to merge 1 commit into
mainfrom
dev
Open

fix: change logging output from stdout to stderr#4
aeroxy wants to merge 1 commit into
mainfrom
dev

Conversation

@aeroxy

@aeroxy aeroxy commented Jun 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request changes the tracing subscriber's output destination from standard output (std::io::stdout) to standard error (std::io::stderr). The review feedback correctly points out that the variable name 'stdout_layer' is now misleading and suggests renaming it to 'stderr_layer' or 'console_layer' to maintain code readability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/main.rs

let stdout_layer = tracing_subscriber::fmt::layer()
.with_writer(std::io::stdout)
.with_writer(std::io::stderr)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The variable stdout_layer (defined on line 208) is now misleading because the destination has been changed to std::io::stderr. To maintain readability and prevent confusion, consider renaming stdout_layer to stderr_layer or console_layer throughout this function.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ee95cba4-0531-4303-bccf-960849ffe87a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aeroxy

aeroxy commented Jun 10, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the logging configuration in src/main.rs to direct standard log output to stderr instead of stdout by replacing stdout_layer with stderr_layer. There are no review comments provided, and I have no additional feedback on these changes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@aeroxy

aeroxy commented Jun 10, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates src/main.rs to redirect the default tracing output from standard output (std::io::stdout) to standard error (std::io::stderr). There are no review comments provided, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant