Open
Conversation
geuben
reviewed
Jan 10, 2019
| from urllib.parse import quote_plus | ||
| from pytz import timezone | ||
| from tzwhere import tzwhere | ||
| from django.conf.settings import GOOGLE_MAPS_API_KEY |
There was a problem hiding this comment.
tying this to Django isn't a good idea.
Contributor
There was a problem hiding this comment.
yeah this is supposed to be a simple library which isn't tied to django. Let's make this part of the signature?
sils
requested changes
Jun 17, 2020
| from urllib.parse import quote_plus | ||
| from pytz import timezone | ||
| from tzwhere import tzwhere | ||
| from django.conf.settings import GOOGLE_MAPS_API_KEY |
Contributor
There was a problem hiding this comment.
yeah this is supposed to be a simple library which isn't tied to django. Let's make this part of the signature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.