Fix SEPSolver comment on separator direction behavior#60
Merged
aewallin merged 1 commit intoaewallin:masterfrom Mar 21, 2026
Merged
Fix SEPSolver comment on separator direction behavior#60aewallin merged 1 commit intoaewallin:masterfrom
aewallin merged 1 commit intoaewallin:masterfrom
Conversation
Co-authored-by: micycle1 <9304234+micycle1@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this comment is misleading (found during work in my fork of the Java port).
It's mathematically correct in the abstract, but it describes a general solver that never actually occurs... The VD construction guarantees that (-a1,-b1) is always the correct separator direction, regardless of what k1 value arrives at the solver.