Conversation
Introduce a `provider` parameter to `run_evaluations` and `run_evaluations_async` that accepts a `TraceProvider` to fetch evaluation data by session_id instead of requiring a task callable. Add `_resolve_task` static method to validate mutual exclusivity between `task` and `provider` and generate the appropriate callable.
afarntrog
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Remove the TraceProvider integration from run_evaluations and run_evaluations_async, making the task parameter required instead of optional. This removes the _resolve_task static method and the provider parameter, simplifying the evaluation API by requiring callers to always pass a task callable directly.
afarntrog
had a problem deploying
to
auto-approve
GitHub Actions
Failure
Narrow the return type from bare `Callable` to `Callable[[Case], TaskOutput]` and update the docstring to match. This improves type safety and editor support for consumers of `as_task`.
afarntrog
had a problem deploying
to
auto-approve
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
providerparameter torun_evaluationsandrun_evaluations_asyncthat accepts aTraceProviderto fetch evaluation data by session_id instead of requiring a task callable. Add_resolve_taskstatic method to validate mutual exclusivity betweentaskandproviderand generate the appropriate callable.Description
Related Issues
Documentation PR
Type of Change
Bug fix
New feature
Breaking change
Documentation update
Other (please describe):
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.