Skip to content

fix(ST-28): read deployed images for lockdown #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afaryy merged 1 commit into from
Aug 30, 2026
+15 −2
Merged

fix(ST-28): read deployed images for lockdown #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/public-domain-control.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,12 @@ jobs:
set -euo pipefail
api_prefix="memory-director/sandbox/app-api"
web_prefix="memory-director/sandbox/app-web"
api_image="$(terraform -chdir=infra/terraform/components/app init -reconfigure -backend-config="bucket=${{ steps.config.outputs.state_bucket }}" -backend-config="prefix=$api_prefix" >/dev/null && terraform -chdir=infra/terraform/components/app output -raw api_image)"
web_image="$(terraform -chdir=infra/terraform/components/app init -reconfigure -backend-config="bucket=${{ steps.config.outputs.state_bucket }}" -backend-config="prefix=$web_prefix" >/dev/null && terraform -chdir=infra/terraform/components/app output -raw web_image)"
api_image="$(gcloud run services describe "${{ steps.config.outputs.resource_name }}-api" --project "${{ steps.config.outputs.project_id }}" --region "${{ steps.config.outputs.region }}" --format='value(spec.template.spec.containers[0].image)')"
web_image="$(gcloud run services describe "${{ steps.config.outputs.resource_name }}-web" --project "${{ steps.config.outputs.project_id }}" --region "${{ steps.config.outputs.region }}" --format='value(spec.template.spec.containers[0].image)')"
mcp_endpoint="$(gcloud run services describe "${{ steps.config.outputs.resource_name }}-mcp" --project "${{ steps.config.outputs.project_id }}" --region "${{ steps.config.outputs.region }}" --format='value(status.url)')"
test -n "$api_image"
test -n "$web_image"
test -n "$mcp_endpoint"
terraform -chdir=infra/terraform/components/app init -reconfigure -backend-config="bucket=${{ steps.config.outputs.state_bucket }}" -backend-config="prefix=$api_prefix"
terraform -chdir=infra/terraform/components/app apply -auto-approve \
-var="project_config=${{ steps.config.outputs.project_config_file }}" \
Expand Down
10 changes: 10 additions & 0 deletions infra/terraform/tools/config-validator/test/public-edge-assets.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,13 @@ test("serverless NEG backends do not set unsupported backend timeouts", () => {
const module = readFileSync(new URL("infra/terraform/modules/foundations/public_edge/main.tf", repositoryRoot), "utf8");
assert.doesNotMatch(module, /resource "google_compute_backend_service" "(?:api|web)" \{[\s\S]*?timeout_sec/);
});

test("lockdown reads the deployed Cloud Run images instead of absent Terraform state outputs", () => {
const workflow = readFileSync(new URL(".github/workflows/public-domain-control.yml", repositoryRoot), "utf8");
assert.match(workflow, /gcloud run services describe "\$\{\{ steps\.config\.outputs\.resource_name \}\}-api".*--format='value\(spec\.template\.spec\.containers\[0\]\.image\)'/s);
assert.match(workflow, /gcloud run services describe "\$\{\{ steps\.config\.outputs\.resource_name \}\}-web".*--format='value\(spec\.template\.spec\.containers\[0\]\.image\)'/s);
assert.match(workflow, /test -n "\$api_image"/);
assert.match(workflow, /test -n "\$web_image"/);
assert.match(workflow, /test -n "\$mcp_endpoint"/);
assert.doesNotMatch(workflow, /terraform -chdir=infra\/terraform\/components\/app output -raw (?:api_image|web_image)/);
});
Loading