Skip to content

fix(ST-28): serialize deployment and lockdown - #58

Merged
afaryy merged 1 commit into
mainfrom
fix/ST-28-deploy-lockdown-race
Aug 30, 2026
Merged

fix(ST-28): serialize deployment and lockdown#58
afaryy merged 1 commit into
mainfrom
fix/ST-28-deploy-lockdown-race

Conversation

@afaryy

@afaryy afaryy commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Root cause

A post-merge deployment and the manually dispatched lockdown ran under different concurrency groups. Deploy used the Terraform default public_ingress=true, reopening services that lockdown had just restricted.

Changes

  • serialize application deployment and public-domain control with the same non-cancelling concurrency group
  • preserve the existing API/Web ingress mode during deployment
  • treat only explicit Cloud Run NOT_FOUND as an absent service; other probe errors fail closed
  • add regression coverage for the shared lock and ingress propagation

Verification

  • npm test in infra/terraform/tools/config-validator — 9 passing
  • git diff --check
  • independent review completed; P1 fail-open finding fixed and re-reviewed

Follow-up

After this PR merges and its automatic deployment completes, run the guarded lockdown workflow once more. It will lock both services; future deployments will preserve that state.

@afaryy
afaryy merged commit 492b9ef into main Aug 30, 2026
10 checks passed
@afaryy
afaryy deleted the fix/ST-28-deploy-lockdown-race branch August 30, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant