fix(ST-28): serialize deployment and lockdown - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
A post-merge deployment and the manually dispatched lockdown ran under different concurrency groups. Deploy used the Terraform default
public_ingress=true, reopening services that lockdown had just restricted.Changes
NOT_FOUNDas an absent service; other probe errors fail closedVerification
npm testininfra/terraform/tools/config-validator— 9 passinggit diff --checkFollow-up
After this PR merges and its automatic deployment completes, run the guarded
lockdownworkflow once more. It will lock both services; future deployments will preserve that state.