fix(deploy): bound captured command output - #85
Open
andrewkcchung wants to merge 1 commit into
Open
andrewkcchung wants to merge 1 commit into
andrewkcchung wants to merge 1 commit into
Conversation
Raise the synchronous command runner capacity above Node's default while retaining a finite ceiling and covering ENOBUFS through public behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deployment and rendering tools can legitimately emit more output than Node's default synchronous-process buffer, causing otherwise successful operations to fail with
ENOBUFS. A named, finite platform bound makes these commands reliable while keeping memory use explicit and preventing callers from selecting an unbounded capture size.What changed
Behavioral proof
Command:
main: The large-output regression failed withENOBUFSunder the previous default-buffer behavior.Risk assessment
Relative risk: Low
The change adjusts one shared deployment command-runner resource bound without changing command construction or execution semantics. Memory remains explicitly capped at 64 MiB per stream. Tests reproduce the prior
ENOBUFSfailure and reject invalid or unbounded overrides; peak memory when both streams fill is the main review concern.Review focus