feat(ui-core): add worker timeline layout helpers - #87
Open
andrewkcchung wants to merge 1 commit into
Open
andrewkcchung wants to merge 1 commit into
andrewkcchung wants to merge 1 commit into
Conversation
Keep deterministic lane ordering and bounded zoom geometry in DOM-free UI core helpers with boundary-focused tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Timeline renderers need the same deterministic answers for visible-span zoom and worker-lane order regardless of which product surface renders them. Keeping these calculations as pure UI-core helpers prevents renderer-specific copies, makes layout behavior testable without a DOM, and provides a reusable foundation for current and future timelines.
What changed
Behavioral proof
Command:
main: The test failed because the shared timeline helper modules did not exist onmain.Risk assessment
Relative risk: Low
The contribution is additive, pure, DOM-independent UI-core logic and does not yet replace an existing renderer path. Its risk is limited to the public geometry and ordering contract exposed for future consumers. Deterministic boundary, duplicate-lane, immutability, and chart-cap tests constrain that behavior.
Review focus