Repository navigation
Conversation
A comment added to write_unit's heredoc in 0.1.6 (SUP-6) quoted `rnfs get` in backticks. The heredoc is unquoted, so it can fill in the launcher's path, and the shell ran rnfs get while writing the unit: a usage error at install and update, and a garbled comment line in the unit. Drop the backticks, and add a test that the heredoc runs nothing but the launcher's systemd_quote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment added to write_unit's heredoc in 0.1.6 (SUP-6) quoted
rnfs getin backticks. The heredoc is unquoted, so it can fill in the launcher's path, and the shell ran rnfs get while writing the unit: a usage error at install and update, and a garbled comment line in the unit. Drop the backticks, and add a test that the heredoc runs nothing but the launcher's systemd_quote.