Climate download#2
Open
molotomt wants to merge 23 commits into
Open
Conversation
paulmwatson
requested changes
Apr 12, 2023
paulmwatson
left a comment
paulmwatson
left a comment
Collaborator
There was a problem hiding this comment.
Also please update the readme with instructions on how to run the files and what extra files are needed that are not in the repo (./files)
| import pandas as pd | ||
| import numpy as np | ||
|
|
||
| df = pd.read_csv('~/dev/climate-datasets/files/emdat_africa_1992-2023_natural.csv', encoding = 'unicode_escape', engine ='python') |
Collaborator
There was a problem hiding this comment.
The ~/dev/climate-datasets/files is specific to your machine, and Linux style file systems, rather use local ./files
| print('Fetching Data') | ||
|
|
||
| climatology_df = pd.read_csv('emdat_africa_1992-2023_natural.csv') | ||
| #print(climatology_df) |
Collaborator
There was a problem hiding this comment.
Remove commented out code
Comment on lines
+28
to
+56
| file_info =[{ | ||
| "filename": "TAVG-climatology.csv", | ||
| "resource_id": os.getenv('TAVG_climate_resource_id') | ||
| }, | ||
| { | ||
| "filename": "TAVG-temperature.csv", | ||
| "resource_id": os.getenv('TAVG_temp_resource_id') | ||
|
|
||
| }, | ||
| { | ||
| "filename": "TMAX-climatology.csv", | ||
| "resource_id": os.getenv('TMAX_climate_resource_id') | ||
|
|
||
| }, | ||
| { | ||
| "filename": 'TMAX-temperature.csv', | ||
| "resource_id": os.getenv('TMAX_temp_resource_id') | ||
|
|
||
| }, | ||
| { | ||
| "filename": "TAVG-climatology.csv", | ||
| "resource_id": os.getenv('TMIN_climate_resource_id') | ||
|
|
||
| }, | ||
| { | ||
| "filename": 'TMIN-temperature.csv', | ||
| "resource_id": os.getenv('TMIN_temp_resource_id') | ||
|
|
||
| }] |
Collaborator
There was a problem hiding this comment.
Block repeated in several files. Best to extract and import.
|
|
||
| load_dotenv() | ||
|
|
||
| # Define CKAN API endpoint and your API key] |
Collaborator
There was a problem hiding this comment.
Bracket at end of comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.