Repository navigation
fix(utoopack): publish 0.2 dev HTML from client build callbacks - #157
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27d20837dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ( | ||
| !clientBuildReceived && | ||
| plan.entries.some((entry) => entry.environment === "client") | ||
| ) { | ||
| throw new Error( | ||
| "[evjs] Utoopack dev requires @utoo/pack with onClientBuild support. Upgrade @utoo/pack before starting ev dev.", |
There was a problem hiding this comment.
For installations using the committed lockfile, the adapter still resolves @utoo/pack to 1.4.27, while this change requires the newer onClientBuild support identified in the commit message. Removing the stats watcher and throwing when that callback has not run makes ordinary client apps fail to start with the dependency this repository installs. Update the adapter's minimum dependency version and lockfile to a release containing the callback, or retain a compatible fallback until that release is available; the mocked compatibility test does not validate the locked package.
Useful? React with 👍 / 👎.
Replace stats file watching with Utoopack's awaited
onClientBuildcallback so development HTML and manifests stay in sync when client chunk names change.Requires an
@utoo/packrelease containing utooland/utoo#3432.