Skip to content

fix(client): forward framework HTTP fetch adapters - #158

Merged
xusd320 merged 1 commit into
mainfrom
xusd320/fix-framework-http-fetch
Oct 31, 2026
Merged

xusd320 merged 1 commit into
mainfrom
xusd320/fix-framework-http-fetch

Conversation

@xusd320

@xusd320 xusd320 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Preserve the existing ApiClientOptions.fetch adapter when a framework transport resolver supplies it. The framework factory currently drops it and always uses global fetch.

Changes

  • Allow the internal transport resolver to return ApiClientOptions and forward its fetch adapter to the native HTTP client.
  • Keep application configuration and the default transport reader unchanged.
  • Add coverage for scoped adapters and native JSON, headers, credentials, and AbortSignal forwarding.

Validation

  • npm run check-types passed.
  • npm run lint passed.
  • npm test passed: 101 files / 2174 tests, including 271 client tests.
  • New regression fails without fetch forwarding and passes with it.
  • git diff --check passed.

Risk / rollout

  • Backward compatible: clients without a fetch adapter continue to use global fetch.
  • Release is needed before the internal EVJS transport simplification can use this hook.

Reviewer notes

  • Production changes are limited to the internal resolver return type and forwarding the existing fetch option. This PR does not add an application config API.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T12:26:57.424895Z 3e445d6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@xusd320
xusd320 merged commit f476143 into main Oct 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant