Replace deprecated pkg_resources with importlib.resources#25
Open
Chowdhury-Anik wants to merge 2 commits into
Open
Replace deprecated pkg_resources with importlib.resources#25Chowdhury-Anik wants to merge 2 commits into
Chowdhury-Anik wants to merge 2 commits into
Conversation
This fixes the deprecation warning by migrating from pkg_resources to importlib.resources. Changes: - Replaced 'from pkg_resources import resource_filename' with 'from importlib.resources import files' - Updated all resource_filename(__name__, path) calls to str(files(__name__).joinpath(path)) This ensures compatibility with Python 3.7+ and Setuptools >= 81.0.0. Fixes ageitgey/face_recognition#1645
turicas
approved these changes
Nov 27, 2025
dimpase
reviewed
Nov 28, 2025
add the missing ' )' in str(files(__name__).joinpath(...))
|
Let's merge this please? |
|
god please can this be merged, i burnt like a whole day recreating my venv's / recompiling face_recognition on a slow raspberry pi before i figured out that it was an issue with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the deprecation warning by migrating from pkg_resources to importlib.resources.
Changes:
This ensures compatibility with Python 3.7+ and Setuptools >= 81.0.0.
Fixes ageitgey/face_recognition#1645