Skip to content

test(store): drop double-close on raw sqlite handle in legacy-shape test #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ojongerius merged 2 commits into from
May 22, 2026
Merged

test(store): drop double-close on raw sqlite handle in legacy-shape test #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
493c07d
test(store): remove double-close on raw sqlite handle in legacy-shape…
ojongerius May 22, 2026
e101138
test(store): t.Cleanup as failure-path Close safety net
ojongerius May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions internal/store/reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,13 @@ func TestReader_ListReceipts_OutputStatusMismatch_LegacyShape(t *testing.T) {
if err != nil {
t.Fatalf("open raw sqlite: %v", err)
}
defer db.Close()
// Failure-path safety net: if any t.Fatalf below short-circuits the
// explicit Close, t.Cleanup still releases the handle. database/sql's
// DB.Close is idempotent (sets a `closed` flag, subsequent calls return
// nil), so this is a no-op on the happy path. The explicit Close before
// OpenReadOnly is the load-bearing one — it surfaces errors and quiesces
// the file before the reader opens it.
t.Cleanup(func() { _ = db.Close() })

const legacyReceiptJSON = `{
"@context":["https://www.w3.org/ns/credentials/v2","https://agentreceipts.ai/context/v1"],
Expand Down Expand Up @@ -591,7 +597,9 @@ func TestReader_ListReceipts_OutputStatusMismatch_LegacyShape(t *testing.T) {
); err != nil {
t.Fatalf("insert legacy receipt: %v", err)
}
db.Close()
if err := db.Close(); err != nil {
t.Fatalf("close raw sqlite: %v", err)
}

reader, err := OpenReadOnly(dbPath)
if err != nil {
Expand Down