Skip to content

docs: add guide for CSI based external volumes - #1072

Merged
hajiler merged 1 commit into
agent-substrate:mainfrom
hajiler:doc-worktree
Aug 27, 2026
Merged

docs: add guide for CSI based external volumes#1072
hajiler merged 1 commit into
agent-substrate:mainfrom
hajiler:doc-worktree

Conversation

@hajiler

@hajiler hajiler commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

#232

Add documentation guide for CSI volumes in Substrate

  • [X ] Tests pass
  • [ X] Appropriate changes to documentation are included in the PR

Comment thread docs/api-guide.md Outdated
Comment thread docs/csi-volumes.md Outdated
Comment thread docs/csi-volumes.md Outdated
Comment thread docs/csi-volumes.md Outdated
@hajiler
hajiler force-pushed the doc-worktree branch 2 times, most recently from f41fb3c to 1eddc9c Compare August 26, 2026 17:52
Comment thread docs/csi-deployment.md Outdated
Comment thread docs/csi-deployment.md Outdated
Comment thread docs/csi-deployment.md
nodeSocketOverride: unix:///var/lib/kubelet/plugins/csi-nfsplugin/csi.sock
tls:
enabled: true
usePodIdentity: true

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if podIdentity is false?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not allowed by validation logic:

// +kubebuilder:validation:XValidation:rule="!self.enabled || (has(self.usePodIdentity) && self.usePodIdentity)",message="tls.usePodIdentity must be true when tls.enabled is true; manual certificates are not yet supported"
, I added a section on that.

@msau42

Copy link
Copy Markdown
Collaborator

lgtm, it looks like the tests are failing for some unrelated changes, you may need to rebase

@hajiler
hajiler force-pushed the doc-worktree branch 2 times, most recently from 45092fe to 974e3a8 Compare August 27, 2026 22:07
TAG=agy
CONV=872d25ed-2cb8-4575-a986-6a9b315f1fb6
@hajiler
hajiler merged commit b4529fc into agent-substrate:main Aug 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants