Skip to content

Extend declarative validation to ActorSnapshotTags #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shrutiyam-glitch wants to merge 9 commits into from
Closed

Extend declarative validation to ActorSnapshotTags #1260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0ae57c9
add dv to ActorSnapshotTag
shrutiyam-glitch Aug 27, 2026
17c45a3
Add dv for ActorSnapshotTag create,update and delete requests
shrutiyam-glitch Aug 27, 2026
4e980bd
Merge branch 'main' into snapshot-dv
shrutiyam-glitch Aug 27, 2026
909ab9c
Add DV for the ActorSnapshot and tag read and list requests
shrutiyam-glitch Aug 27, 2026
a4e6163
Use setMetadata and add comments
shrutiyam-glitch Aug 27, 2026
ce77f7b
Merge branch 'main' into snapshot-dv
shrutiyam-glitch Aug 28, 2026
ebb65b0
fix exemptions
shrutiyam-glitch Aug 28, 2026
4b6a847
Merge branch 'main' into snapshot-dv
shrutiyam-glitch Aug 28, 2026
aee2127
Update exemptions
shrutiyam-glitch Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
253 changes: 113 additions & 140 deletions cmd/ateapi/internal/controlapi/actor_snapshot.go
View file
Open in desktop

Large diffs are not rendered by default.

591 changes: 430 additions & 161 deletions cmd/ateapi/internal/controlapi/actor_snapshot_test.go
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions cmd/ateapi/internal/controlapi/functionaltest/actor_snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,10 @@ func TestUpdateActorSnapshotTag_Preconditions(t *testing.T) {
if uid == staleUID {
t.Fatalf("recreated tag reused uid %s, want a fresh one", uid)
}
// No preconditions
// No preconditions. Presence of the guards is the store's to enforce, so
// the rejection carries its wording rather than field paths.
_, err := update(&ateapipb.ResourceMetadata{}, ateapipb.ActorSnapshotTagScope_ACTOR_SNAPSHOT_TAG_SCOPE_PUBLISHED)
assertGrpcError(t, err, codes.InvalidArgument, "[actor_snapshot_tag.metadata.uid: Required value, actor_snapshot_tag.metadata.version: Required value]")
assertGrpcError(t, err, codes.InvalidArgument, fmt.Sprintf("while updating actor snapshot tag %s/%s: persistence: precondition required: uid", testAtespace, tagName))

// The uid from the deleted lifecycle must be rejected, even though the
// atespace/name it was observed under still resolves and the version it
Expand Down
Loading
Loading