api: drop ActorTemplateStatus.sandbox_assets for now - #1300
Merged
Dmitry Berkovich (dberkov) merged 2 commits intoAug 29, 2026
Conversation
Zoe Zhao (zoez7)
requested review from
Dmitry Berkovich (dberkov) and
Julian Gutierrez Oschmann (juli4n)
August 28, 2026 20:54
Dmitry Berkovich (dberkov)
previously approved these changes
Aug 29, 2026
Collaborator
|
needs rebase / codegen. also prefer rebase to merge so the commit history is cleaner (even after squash merge this is helpful for tracing back) |
Remove ActorTemplateStatus.sandbox_assets along with the SandboxAssets, ArchAssets, and AssetFile messages it referenced. Nothing ever wrote the field: sandbox assets are resolved from the WorkerPool and SandboxConfig objects at resume time and travel to atelet via ateletpb, so freezing them into the template status never materialized.
Zoe Zhao (zoez7)
force-pushed
the
drop-sandbox-assets
branch
from
August 29, 2026 16:16
7634636 to
f5a7d6a
Compare
Dmitry Berkovich (dberkov)
merged commit Aug 29, 2026
e1adb33
into
agent-substrate:main
9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
ActorTemplateStatus.sandbox_assetsalong with theSandboxAssetsmessages it referenced. Nothing ever wrote the field: sandbox assets are resolved from the WorkerPool and SandboxConfig objects at resume time and travel to atelet via ateletpb, so freezing them into the template status never materialized.This requires more thought, one option is to add it as a field of GoldenSnapshotStatus in the future, and make GoldenSnapshotStatus a repeated field to allow multiple goldens.