actorTemplate(fix): update volume mount validation - #1448
Merged
Michelle Au (msau42) merged 2 commits intoSep 4, 2026
Merged
Conversation
shrutiyam-glitch
requested review from
Julian Gutierrez Oschmann (juli4n) and
Michelle Au (msau42)
September 3, 2026 19:33
shrutiyam-glitch
force-pushed
the
fix-volume-validation
branch
from
September 3, 2026 21:11
7f7974e to
e4d8f73
Compare
| mutate: func(tmpl *ateapipb.ActorTemplate) { | ||
| tmpl.Containers[0].VolumeMounts = []*ateapipb.VolumeMount{ | ||
| {Name: "data", MountPath: "/data"}, | ||
| {Name: "config", MountPath: "/data/config"}, |
Collaborator
There was a problem hiding this comment.
Can you also test a nested path more than a level deep? Like /data and /data/a/b/c
Michelle Au (msau42)
approved these changes
Sep 4, 2026
Michelle Au (msau42)
merged commit Sep 4, 2026
917efca
into
agent-substrate:main
11 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1435 #1434
Two
ActorTemplatevalidation gaps that pass creation today and fail at runtime, both closed withcustomValidationhooks (neither rule is expressible in tags):Fixes Container
volume_mountscan reference undefined template volumes #1434 — a containervolume_mountnaming a volume the template never declares was accepted, leaving the golden actor permanently stuck inACTOR_STATE_RESUMING. The rule spans two subtrees (containers and volumes), so the hook lives onCreateActorTemplateRequest.actor_template, where it sees the whole template.Fixes Duplicate
mount_pathfor distinct volumes accepted within a container #1435 — two different volumes mounted at the samemount_pathwere accepted (the list-map key is name, so path collisions slipped through); The hook onContainer.volume_mountsenforces path uniqueness within each container. This resolves the todo partially, and also discussed here - Declarative validation for ActorTemplate #1303 (comment)Tests pass
Appropriate changes to documentation are included in the PR