Skip to content

actorTemplate(fix): update volume mount validation - #1448

Merged
Michelle Au (msau42) merged 2 commits into
agent-substrate:mainfrom
shrutiyam-glitch:fix-volume-validation
Sep 4, 2026
Merged

actorTemplate(fix): update volume mount validation#1448
Michelle Au (msau42) merged 2 commits into
agent-substrate:mainfrom
shrutiyam-glitch:fix-volume-validation

Conversation

@shrutiyam-glitch

Copy link
Copy Markdown
Collaborator

Fixes #1435 #1434

Two ActorTemplate validation gaps that pass creation today and fail at runtime, both closed with customValidation hooks (neither rule is expressible in tags):

mutate: func(tmpl *ateapipb.ActorTemplate) {
tmpl.Containers[0].VolumeMounts = []*ateapipb.VolumeMount{
{Name: "data", MountPath: "/data"},
{Name: "config", MountPath: "/data/config"},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test a nested path more than a level deep? Like /data and /data/a/b/c

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 7085bfb

@msau42
Michelle Au (msau42) merged commit 917efca into agent-substrate:main Sep 4, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate mount_path for distinct volumes accepted within a container Container volume_mounts can reference undefined template volumes

2 participants