Refine the onboarding goal flow - #2149
Conversation
yuezengwu
left a comment
There was a problem hiding this comment.
实现目标:把 onboarding 聚焦成“连接电脑 → 创建 First Tree agent → 认识并开始使用 agent”的清晰路径,同时统一所有 agent 创建入口的 runtime 默认偏好。
核心改动:Connect Computer 收敛为 server-authored 的单一 terminal command,并只读展示检测到的可运行选项;runtime 选择移入 Create Agent;新增共享 Codex → Claude Code → 其余 ready provider 的排序逻辑,保留仍有效的用户选择;最后一步改为 “Meet your agent / Start exploring”,但继续沿用原有 chat 创建、bootstrap 与 completion 行为;Preview 也改为直接复用 production components 的聚焦场景。
Review 结论:没有 blocking findings。admin/invitee 步骤序列、disabled-provider 过滤、client capability staleness 边界和 start-chat 状态模型都保持完整;无核心数据结构或数据库变更。
Non-blocking:Codex-first 是跨 agent-creation surface 的持久产品决策,当前 Context Tree 的 system/cloud/onboarding.md 尚未明确记录该 preference。建议按 source-driven Tree workflow 补充这一点;纯 UI 文案和组件实现细节无需进入 Tree。
baixiaohang
left a comment
There was a problem hiding this comment.
Recommendation: approve
- Rationale: The onboarding journey is clearer and the Codex-first preference is centralized without changing the established step sequence, kickoff behavior, or capability-staleness guards.
Risk level: C
- Path baseline: all changes are under
packages/web/**-> C - Semantic lift: none; the diff does not change subscriptions, WebSocket frame handling, or a backend data contract.
PR summary
- Author / repo: Gandy2025 / agent-team-foundation/first-tree
- Problem: New members currently encounter competing connection paths, inconsistent runtime defaults, and a finale framed around Chat mechanics instead of meeting and using their agent.
- Approach: Keep the existing admin/invitee onboarding sequence while presenting one server-authored terminal command, moving the visible runtime choice into Create Agent, sharing a Codex-first preference across both agent-creation surfaces, and reframing the unchanged first-chat launch as “Meet your agent / Start exploring.” Preview scenarios now render the production steps directly.
- Impacted modules: Web onboarding steps and copy, shared agent-setup hooks, New Agent dialog, and onboarding preview/test fixtures.
Review findings
✅ 1. The shared ordering helper preserves a still-ready user selection, consistently filters disabled providers at each capability boundary, and leaves the existing start-chat completion path intact.
CommunityChannels(includeMobile) branch with no caller and its shared-surface comments stale. Consider removing that dead branch/import chain in a follow-up. [R2 / packages/web/src/components/community-channels.tsx:38]
Action taken
- Approved.
|
Thanks for both reviews.
No source change is required for either approved review finding in this PR. |
|
Context Tree follow-up: https://github.com/agent-team-foundation/first-tree-context/pull/881 captures the durable Codex-first agent-creation preference established here. The Tree change is ready for its normal owner/reviewer workflow. |
Summary
Product decisions
Validation
pnpm --filter @first-tree/web test— 240 files, 2,101 tests passedpnpm --filter @first-tree/web typecheckpnpm --filter @first-tree/shared build && pnpm --filter @first-tree/web buildgit diff --checkReview