Skip to content

Refine the onboarding goal flow - #2149

Merged
Gandy2025 merged 1 commit into
mainfrom
feat/onboarding-goal-flow
Aug 4, 2026
Merged

Refine the onboarding goal flow#2149
Gandy2025 merged 1 commit into
mainfrom
feat/onboarding-goal-flow

Conversation

@Gandy2025

Copy link
Copy Markdown
Contributor

Summary

  • simplify the real onboarding Connect Computer step to one terminal path and explain what the connection enables
  • move runtime selection into Create Agent, establish the multi-agent model, and use a shared Codex-first runtime preference across agent-creation surfaces
  • rename the final onboarding step to Meet your agent with an exploration-oriented CTA, while preserving the existing Chat creation and bootstrap behavior
  • replace stale Preview-only onboarding mockups with focused scenarios rendered from production components

Product decisions

  • Admin Step 1 and the underlying onboarding step sequence are unchanged
  • runtime preference is Codex, then Claude Code, then remaining ready providers in capability order; a still-valid user selection is preserved
  • the in-Chat concept journey, Context Tree education, provider authorization, and second-agent education remain out of scope

Validation

  • pnpm --filter @first-tree/web test — 240 files, 2,101 tests passed
  • pnpm --filter @first-tree/web typecheck
  • pnpm --filter @first-tree/shared build && pnpm --filter @first-tree/web build
  • Biome check and git diff --check
  • real-browser checks for Admin and Invitee flows at desktop and 390 px product width; no horizontal overflow and primary actions remain visible

Review

  • standards/architecture review: no blocking findings
  • product/state-model review: no blocking findings

@yuezengwu yuezengwu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

实现目标:把 onboarding 聚焦成“连接电脑 → 创建 First Tree agent → 认识并开始使用 agent”的清晰路径,同时统一所有 agent 创建入口的 runtime 默认偏好。

核心改动:Connect Computer 收敛为 server-authored 的单一 terminal command,并只读展示检测到的可运行选项;runtime 选择移入 Create Agent;新增共享 Codex → Claude Code → 其余 ready provider 的排序逻辑,保留仍有效的用户选择;最后一步改为 “Meet your agent / Start exploring”,但继续沿用原有 chat 创建、bootstrap 与 completion 行为;Preview 也改为直接复用 production components 的聚焦场景。

Review 结论:没有 blocking findings。admin/invitee 步骤序列、disabled-provider 过滤、client capability staleness 边界和 start-chat 状态模型都保持完整;无核心数据结构或数据库变更。

Non-blocking:Codex-first 是跨 agent-creation surface 的持久产品决策,当前 Context Tree 的 system/cloud/onboarding.md 尚未明确记录该 preference。建议按 source-driven Tree workflow 补充这一点;纯 UI 文案和组件实现细节无需进入 Tree。

@baixiaohang baixiaohang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: approve

  • Rationale: The onboarding journey is clearer and the Codex-first preference is centralized without changing the established step sequence, kickoff behavior, or capability-staleness guards.

Risk level: C

  • Path baseline: all changes are under packages/web/** -> C
  • Semantic lift: none; the diff does not change subscriptions, WebSocket frame handling, or a backend data contract.

PR summary

  • Author / repo: Gandy2025 / agent-team-foundation/first-tree
  • Problem: New members currently encounter competing connection paths, inconsistent runtime defaults, and a finale framed around Chat mechanics instead of meeting and using their agent.
  • Approach: Keep the existing admin/invitee onboarding sequence while presenting one server-authored terminal command, moving the visible runtime choice into Create Agent, sharing a Codex-first preference across both agent-creation surfaces, and reframing the unchanged first-chat launch as “Meet your agent / Start exploring.” Preview scenarios now render the production steps directly.
  • Impacted modules: Web onboarding steps and copy, shared agent-setup hooks, New Agent dialog, and onboarding preview/test fixtures.

Review findings
✅ 1. The shared ordering helper preserves a still-ready user selection, consistently filters disabled providers at each capability boundary, and leaves the existing start-chat completion path intact.
⚠️ 2. Removing the onboarding community footer leaves the CommunityChannels(includeMobile) branch with no caller and its shared-surface comments stale. Consider removing that dead branch/import chain in a follow-up. [R2 / packages/web/src/components/community-channels.tsx:38]

Action taken

  • Approved.

@Gandy2025

Copy link
Copy Markdown
Contributor Author

Thanks for both reviews.

  • I evaluated the Codex-first preference through the source-driven Context Tree workflow. It passes the durability and decision tests, and the canonical target is the cross-surface agent runtime-binding decision, with onboarding linking to it. Publication is currently blocked by the required Tree verification gate: the current Context Tree origin/main fails validation because SCOPE.md lacks the verifier-required title and owners frontmatter. I did not bypass the gate, publish a Tree branch, or mix that unrelated baseline repair into this source-driven update.
  • I am leaving the now-unused CommunityChannels(includeMobile) cleanup out of this PR. It is non-blocking shared-component cleanup and does not belong in the focused onboarding behavior change; it can be removed separately with its shared-surface comments and tests reviewed together.

No source change is required for either approved review finding in this PR.

@Gandy2025
Gandy2025 merged commit 1261531 into main Aug 4, 2026
19 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2026
@yuezengwu

Copy link
Copy Markdown
Contributor

Context Tree follow-up: https://github.com/agent-team-foundation/first-tree-context/pull/881 captures the durable Codex-first agent-creation preference established here. The Tree change is ready for its normal owner/reviewer workflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants