ci: prefix-match the prod smoke commit assertion - #85
Merged
Conversation
The estate envelope reports the 7-char short sha in `commit` (the full one is in `version`), so the equality test against github.sha failed a deploy that had actually succeeded - prod was serving the new build the whole time.
|
✅ CI - Verify PASSED Commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production deploy of #83 succeeded - prod served the new build within seconds - but the job went red anyway:
The smoke compares
/health'scommitagainstgithub.shawith=. The estate envelope reports the 7-char short sha there; the full one lives inversion. So the assertion can never pass again.Prefix-matches instead, the same fix
agentage/api-gatewayneeded for its two scripts. Works whether the service reports the short or the full form, so it survives any service that has not adopted the kit yet.