ci: verify master after a merge, not just in PRs - #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing verified
masterafter a merge - this repo ranpr-validation.ymlonly, so the first signal that master was broken was a deploy or a publish.pr-validation.ymlbecomesci.ymland gains apush: mastertrigger. Same steps, same job; it now runs in both places.Two details worth noting:
pr-${{ github.event.pull_request.number }}, which is empty on a push - every master push would land in one shared group and cancel the one before it, mid-verify. It is now keyed ongithub.ref.ci.ymlmeans verify, on master and on PRs. Part of aligning the estate on five reserved workflow names (ci/deploy/release/train/_*).