Skip to content

fix: Map priority mode to fast#327

Open
benbrandt wants to merge 1 commit into
mainfrom
priority-mode
Open

fix: Map priority mode to fast#327
benbrandt wants to merge 1 commit into
mainfrom
priority-mode

Conversation

@benbrandt

Copy link
Copy Markdown
Member

Closes #285

Copilot AI review requested due to automatic review settings July 22, 2026 09:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an ACP fast-mode regression where Codex normalizes the configured fast tier to the canonical priority tier, causing codex-acp to incorrectly initialize Fast mode as disabled and then clear the session tier on first prompt.

Changes:

  • Treat serviceTier: "priority" as Fast mode enabled when initializing/resuming a session (same as "fast").
  • Introduce a small helper (serviceTierEnablesFast) and a widened tier type (SupportedServiceTier) to represent Codex’s canonical tier value.
  • Add a Vitest case ensuring a priority session tier results in serviceTier: "fast" being sent on the first turn.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/FastModeConfig.ts Adds SupportedServiceTier and serviceTierEnablesFast() to treat "priority" as enabling Fast mode.
src/CodexAcpServer.ts Uses serviceTierEnablesFast() to initialize fastModeEnabled for new/resumed sessions.
src/CodexAcpClient.ts Stores response.serviceTier as SupportedServiceTier in SessionMetadata to preserve "priority".
src/tests/CodexACPAgent/fast-mode-config.test.ts Adds coverage verifying "priority" initializes Fast mode on and triggers serviceTier: "fast" on prompt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fast mode is disabled when Codex reports the canonical priority service tier

2 participants