fix: Map priority mode to fast#327
Open
benbrandt wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an ACP fast-mode regression where Codex normalizes the configured fast tier to the canonical priority tier, causing codex-acp to incorrectly initialize Fast mode as disabled and then clear the session tier on first prompt.
Changes:
- Treat
serviceTier: "priority"as Fast mode enabled when initializing/resuming a session (same as"fast"). - Introduce a small helper (
serviceTierEnablesFast) and a widened tier type (SupportedServiceTier) to represent Codex’s canonical tier value. - Add a Vitest case ensuring a
prioritysession tier results inserviceTier: "fast"being sent on the first turn.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/FastModeConfig.ts | Adds SupportedServiceTier and serviceTierEnablesFast() to treat "priority" as enabling Fast mode. |
| src/CodexAcpServer.ts | Uses serviceTierEnablesFast() to initialize fastModeEnabled for new/resumed sessions. |
| src/CodexAcpClient.ts | Stores response.serviceTier as SupportedServiceTier in SessionMetadata to preserve "priority". |
| src/tests/CodexACPAgent/fast-mode-config.test.ts | Adds coverage verifying "priority" initializes Fast mode on and triggers serviceTier: "fast" on prompt. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #285